-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation updates, ITC in client result, PR 310 follow-up items [v3.6.6] #313
Merged
softwareengineerprogrammer
merged 21 commits into
NREL:main
from
softwareengineerprogrammer:main
Nov 23, 2024
Merged
Documentation updates, ITC in client result, PR 310 follow-up items [v3.6.6] #313
softwareengineerprogrammer
merged 21 commits into
NREL:main
from
softwareengineerprogrammer:main
Nov 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
softwareengineerprogrammer
commented
Nov 19, 2024
•
edited
Loading
edited
- Follow-up items from Fix pump efficiency units #310
- Parse Investment Tax Credit in result - Fervo_Project_Cape-3 capex calculation correct? #312
- Documentation updates (self-reviewed in README documentation updates softwareengineerprogrammer/GEOPHIRES#41):
- Port relevant overview & architecture diagram from v2.0 manual:
- Add example descriptions in table:
- Synchronize Project Red example from workshop: Synchronize workshop case studies with examples #273
… section first in Documentation section, add NREL GEOPHIRES Workshop session recordings Videos section, add HIP-RA & Monte Carlo web interface links.
…Overview sub-header from Documentation section)
README documentation updates
softwareengineerprogrammer
changed the title
ITC in client result, PR 310 follow-up items [v3.6.6]
Documentation updates, ITC in client result, PR 310 follow-up items [v3.6.6]
Nov 20, 2024
2 tasks
2 tasks
2 tasks
jeffbourdier
approved these changes
Nov 23, 2024
kfbeckers
reviewed
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.