Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates, ITC in client result, PR 310 follow-up items [v3.6.6] #313

Merged
merged 21 commits into from
Nov 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
a022fd6
Fix CLGS validation failure message
softwareengineerprogrammer Nov 13, 2024
4f73e48
DefaultValue instead of value
softwareengineerprogrammer Nov 14, 2024
6413ae4
Parse Investment Tax Credit in result - https://github.com/NREL/GEOPH…
softwareengineerprogrammer Nov 19, 2024
4125bd0
Bump version: 3.6.4 → 3.6.5
softwareengineerprogrammer Nov 19, 2024
e49c020
Merge branch 'NREL:main' into main
softwareengineerprogrammer Nov 19, 2024
49d6503
Re-enable S-DAC-GT example test case
softwareengineerprogrammer Nov 19, 2024
8e4fb21
Bump version: 3.6.5 → 3.6.6
softwareengineerprogrammer Nov 19, 2024
a930d60
Link version 3.5 announcement session recording in v3.5 changelog entry
softwareengineerprogrammer Nov 20, 2024
69e51f2
README updates: Tweak descriptions in Examples table, list Parameters…
softwareengineerprogrammer Nov 20, 2024
c7f3f0c
Port overview from GEOPHIRES v2.0 user manual to README
softwareengineerprogrammer Nov 20, 2024
48e2c69
Update Additional Documentation section
softwareengineerprogrammer Nov 20, 2024
5a432b0
Example descriptions; formatting consistency
softwareengineerprogrammer Nov 20, 2024
2eac69d
Link to Documentation section from README overview
softwareengineerprogrammer Nov 20, 2024
57690c2
Address duplicate Overview section check failure (remove unnecessary …
softwareengineerprogrammer Nov 20, 2024
665d9e8
Merge pull request #41 from softwareengineerprogrammer/readme-updates
softwareengineerprogrammer Nov 20, 2024
3617d86
Update Fervo example descriptions/citations
softwareengineerprogrammer Nov 21, 2024
8a06c5b
Add ITC & PTC to examples table
softwareengineerprogrammer Nov 21, 2024
6be1132
Synchronize Project Red example with workshop version https://github.…
softwareengineerprogrammer Nov 21, 2024
b742073
Remove redundant default value definitions from HIP-RA-X tooltip text
softwareengineerprogrammer Nov 22, 2024
e434bc3
Update HIP-RA unit test impacted by previous commit
softwareengineerprogrammer Nov 22, 2024
c96e5dd
Fix README typo
softwareengineerprogrammer Nov 23, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bumpversion.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 3.6.4
current_version = 3.6.6
commit = True
tag = True

Expand Down
2 changes: 1 addition & 1 deletion .cookiecutterrc
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ default_context:
sphinx_doctest: "no"
sphinx_theme: "sphinx-py3doc-enhanced-theme"
test_matrix_separate_coverage: "no"
version: 3.6.4
version: 3.6.6
version_manager: "bump2version"
website: "https://github.com/NREL"
year_from: "2023"
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ Affected users who do not want the new behavior can specify absolute output path
`release <https://github.com/NREL/GEOPHIRES-X/releases/tag/v3.5.0>`__ | `diff <https://github.com/NREL/GEOPHIRES-X/compare/v3.4.0...v3.5.0>`__

Milestone version for case studies, SHR temperatures, and other changes since 3.0.
An overview is given in the July 2024 NREL GEOPHIRES Workshop `Version 3.5 Announcement session recording <https://youtu.be/Bi_l6y6_LQk>`__.

3.5.3: SBT Reservoir Model (Slender Body Theory)

Expand Down
152 changes: 114 additions & 38 deletions README.rst

Large diffs are not rendered by default.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
year = '2024'
author = 'NREL'
copyright = f'{year}, {author}'
version = release = '3.6.4'
version = release = '3.6.6'

pygments_style = 'trac'
templates_path = ['./templates']
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def read(*names, **kwargs):

setup(
name='geophires-x',
version='3.6.4',
version='3.6.6',
license='MIT',
description='GEOPHIRES is a free and open-source geothermal techno-economic simulator.',
long_description='{}\n{}'.format(
Expand Down
2 changes: 1 addition & 1 deletion src/geophires_x/AGSEconomics.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ def Calculate(self, model: Model) -> None:
# use the CLGS-Style economic calculations
err = self.verify(model)
if err > 0:
msg = 'Error: GEOPHIRES failed to Failed to validate CLGS input value. Exiting....'
msg = 'Error: GEOPHIRES failed to validate CLGS input value. Exiting...'
print(msg)
raise RuntimeError(msg)

Expand Down
2 changes: 1 addition & 1 deletion src/geophires_x/AGSWellBores.py
Original file line number Diff line number Diff line change
Expand Up @@ -977,7 +977,7 @@ def Calculate(self, model: Model) -> None:
# do the CLGS-style calculation
err = self.verify(model)
if err > 0:
msg = 'Error: GEOPHIRES failed to Failed to validate CLGS input value. Exiting....'
msg = 'Error: GEOPHIRES failed to validate CLGS input value. Exiting...'
model.logger.fatal(msg)
print(msg)

Expand Down
2 changes: 1 addition & 1 deletion src/geophires_x/SurfacePlantHeatPump.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def __init__(self, model: Model):

self.heat_pump_cop = self.ParameterDict[self.heat_pump_cop.Name] = floatParameter(
"Heat Pump COP",
value=5,
DefaultValue=5,
Min=1,
Max=10,
UnitType=Units.PERCENT,
Expand Down
2 changes: 1 addition & 1 deletion src/geophires_x/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '3.6.4'
__version__ = '3.6.6'
1 change: 1 addition & 0 deletions src/geophires_x_client/geophires_x_result.py
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ class GeophiresXResult:
'Field gathering system costs',
'Total surface equipment costs',
'Exploration costs',
'Investment Tax Credit',
'Total capital costs',
# AGS/CLGS
'Total CAPEX',
Expand Down
20 changes: 10 additions & 10 deletions src/geophires_x_schema_generator/hip-ra-x-request.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
],
"properties": {
"Reservoir Temperature": {
"description": "Reservoir Temperature [150 degC]",
"description": "Reservoir Temperature",
"type": "number",
"units": "degC",
"category": null,
Expand All @@ -26,7 +26,7 @@
"maximum": 1000
},
"Rejection Temperature": {
"description": "Rejection Temperature [25 degC]",
"description": "Rejection Temperature",
"type": "number",
"units": "degC",
"category": null,
Expand All @@ -35,7 +35,7 @@
"maximum": 200
},
"Reservoir Porosity": {
"description": "Reservoir Porosity [18%]",
"description": "Reservoir Porosity",
"type": "number",
"units": "%",
"category": null,
Expand All @@ -44,7 +44,7 @@
"maximum": 100.0
},
"Reservoir Area": {
"description": "Reservoir Area [81 km2]",
"description": "Reservoir Area",
"type": "number",
"units": "km**2",
"category": null,
Expand All @@ -53,7 +53,7 @@
"maximum": 10000.0
},
"Reservoir Thickness": {
"description": "Reservoir Thickness [0.286 km]",
"description": "Reservoir Thickness",
"type": "number",
"units": "kilometer",
"category": null,
Expand All @@ -62,7 +62,7 @@
"maximum": 10000.0
},
"Reservoir Life Cycle": {
"description": "Reservoir Life Cycle [30 years]",
"description": "Reservoir Life Cycle",
"type": "integer",
"units": "yr",
"category": null,
Expand All @@ -71,7 +71,7 @@
"maximum": 100
},
"Rock Heat Capacity": {
"description": "Rock Heat Capacity [2.84E+12 kJ/km3C]",
"description": "Rock Heat Capacity",
"type": "number",
"units": "kJ/km**3C",
"category": null,
Expand All @@ -80,7 +80,7 @@
"maximum": 100000000000000.0
},
"Fluid Specific Heat Capacity": {
"description": "Specific Heat Capacity Of Water [4.18 kJ/kgC]",
"description": "Specific Heat Capacity Of Water",
"type": "number",
"units": "kJ/kgC",
"category": null,
Expand All @@ -89,7 +89,7 @@
"maximum": 10.0
},
"Density Of Reservoir Fluid": {
"description": "Density Of Water [1.0E+12 kg/km3]",
"description": "Density Of Water",
"type": "number",
"units": "kg/km**3",
"category": null,
Expand All @@ -98,7 +98,7 @@
"maximum": 10000000000000.0
},
"Density Of Reservoir Rock": {
"description": "Density Of Rock [2.55E+12 kg/km3]",
"description": "Density Of Rock",
"type": "number",
"units": "kg/km**3",
"category": null,
Expand Down
20 changes: 10 additions & 10 deletions src/hip_ra_x/hip_ra_x.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def parameter_dict_entry(param: Parameter) -> Parameter:
CurrentUnits=TemperatureUnit.CELSIUS,
Required=True,
ErrMessage='assume default reservoir temperature (150 degC)',
ToolTipText='Reservoir Temperature [150 degC]',
ToolTipText='Reservoir Temperature',
)
)
self.rejection_temperature: Parameter = parameter_dict_entry(
Expand All @@ -134,7 +134,7 @@ def parameter_dict_entry(param: Parameter) -> Parameter:
CurrentUnits=TemperatureUnit.CELSIUS,
Required=True,
ErrMessage='assume default rejection temperature (25 degC)',
ToolTipText='Rejection Temperature [25 degC]',
ToolTipText='Rejection Temperature',
)
)
self.reservoir_porosity: Parameter = parameter_dict_entry(
Expand All @@ -148,7 +148,7 @@ def parameter_dict_entry(param: Parameter) -> Parameter:
CurrentUnits=PercentUnit.PERCENT,
Required=True,
ErrMessage='assume default reservoir porosity (18%)',
ToolTipText='Reservoir Porosity [18%]',
ToolTipText='Reservoir Porosity',
)
)
self.reservoir_area: Parameter = parameter_dict_entry(
Expand All @@ -162,7 +162,7 @@ def parameter_dict_entry(param: Parameter) -> Parameter:
CurrentUnits=AreaUnit.KILOMETERS2,
Required=True,
ErrMessage='assume default reservoir area (81 km2)',
ToolTipText='Reservoir Area [81 km2]',
ToolTipText='Reservoir Area',
)
)
self.reservoir_thickness: Parameter = parameter_dict_entry(
Expand All @@ -176,7 +176,7 @@ def parameter_dict_entry(param: Parameter) -> Parameter:
CurrentUnits=LengthUnit.KILOMETERS,
Required=True,
ErrMessage='assume default reservoir thickness (0.286 km2)',
ToolTipText='Reservoir Thickness [0.286 km]',
ToolTipText='Reservoir Thickness',
)
)
self.reservoir_life_cycle: Parameter = parameter_dict_entry(
Expand All @@ -189,7 +189,7 @@ def parameter_dict_entry(param: Parameter) -> Parameter:
AllowableRange=list(range(1, 101, 1)),
Required=True,
ErrMessage='assume default Reservoir Life Cycle (25 years)',
ToolTipText='Reservoir Life Cycle [30 years]',
ToolTipText='Reservoir Life Cycle',
)
)

Expand All @@ -205,7 +205,7 @@ def parameter_dict_entry(param: Parameter) -> Parameter:
CurrentUnits=HeatCapacityUnit.KJPERKM3C,
Required=True,
ErrMessage='assume default Rock Heat Capacity (2.84E+12 kJ/km3C)',
ToolTipText='Rock Heat Capacity [2.84E+12 kJ/km3C]',
ToolTipText='Rock Heat Capacity',
)
)
self.fluid_heat_capacity: Parameter = parameter_dict_entry(
Expand All @@ -219,7 +219,7 @@ def parameter_dict_entry(param: Parameter) -> Parameter:
CurrentUnits=HeatCapacityUnit.kJPERKGC,
Required=True,
ErrMessage='calculate a value based on the water temperature',
ToolTipText='Specific Heat Capacity Of Water [4.18 kJ/kgC]',
ToolTipText='Specific Heat Capacity Of Water',
)
)
self.fluid_density: Parameter = parameter_dict_entry(
Expand All @@ -233,7 +233,7 @@ def parameter_dict_entry(param: Parameter) -> Parameter:
CurrentUnits=DensityUnit.KGPERKILOMETERS3,
Required=True,
ErrMessage='calculate a value based on the water temperature',
ToolTipText='Density Of Water [1.0E+12 kg/km3]',
ToolTipText='Density Of Water',
)
)
self.rock_density: Parameter = parameter_dict_entry(
Expand All @@ -247,7 +247,7 @@ def parameter_dict_entry(param: Parameter) -> Parameter:
CurrentUnits=DensityUnit.KGPERKILOMETERS3,
Required=True,
ErrMessage='assume default Density Of Rock (2.55E+12 kg/km3)',
ToolTipText='Density Of Rock [2.55E+12 kg/km3]',
ToolTipText='Density Of Rock',
)
)
self.rock_recoverable_heat: Parameter = parameter_dict_entry(
Expand Down
Loading