Wrap ZoneHVAC:EvaporativeCoolerUnit #5326

joseph-robertson · 2024-12-18T21:52:05Z

Pull request overview

Fixes Wrap ZoneHVAC:EvaporativeCoolerUnit #5253

Pull Request Author

Model API Changes / Additions
Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
Model API methods are tested (in src/model/test)
EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
If a new object or method, added a test in NREL/OpenStudio-resources: Wrap ZoneHVAC:EvaporativeCoolerUnit OpenStudio-resources#215
If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
All new and existing tests passes
If methods have been deprecated, update rest of code to use the new methods

Labels:

If change to an IDD file, add the label IDDChange
If breaking existing API, add the label APIChange
If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

Perform a Code Review on GitHub
Code Style, strip trailing whitespace, etc.
All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
Labeling is ok
If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
If feature, test running new feature, try creative ways to break it
CI status: all green or justified

resources/model/OpenStudio.idd

jmarrec · 2024-12-19T10:55:36Z

resources/model/OpenStudio.idd

+  A5,  \field Outdoor Air Inlet Node Name
+       \required-field
+       \type object-list
+       \object-list ConnectionNames
+       \note this is an outdoor air node


I think you may want to not add it?

resources/model/OpenStudio.idd

jmarrec · 2024-12-19T11:00:34Z

resources/model/OpenStudio.idd

+  A11, \field First Evaporative Cooler Object Name
+       \required-field
+       \type object-list
+       \object-list EvapCoolerNames
+  A12, \field Second Evaporative Cooler Name


I know this is just E+. still bothers me that the second doesn't have "Object" in it.
In any case, beware here because GenerateClass.rb will name the getters/setters differently and we don't want that.

I'd remove both "Object Name" from it, so that the getters are firstEvaporativeCooler and secondEvaporativeCooler

jmarrec

Pretty minor comments (mostly: tests), this is looking very good otherwise.

jmarrec · 2024-12-24T08:18:05Z

src/model/test/ZoneHVACEvaporativeCoolerUnit_GTest.cpp

Would be good to add tests for:

Nodes/Connections:

addToThermalZone (are the inlet/outlet nodes set correctly)

addToNode.

Not familiar with this object, but at least it should be rejected on a PlantLoop, Not sure about AirLoopHVAC (ZoneHVACComponent will allow a connection with an AirTerminalSingleDuctInletSideMixer). Bottom line: are the addToThermalZone & addToNode from ZoneHVACComponent doing the right thing for this object?

clone: same model, and another model. And remove.

OpenStudio/src/model/ZoneHVACComponent.cpp

Lines 320 to 336 in 0314c3e

bool ZoneHVACComponent_Impl::addToNode(Node& node) {

bool result = false;

boost::optional<ThermalZone> thermalZone;

boost::optional<AirTerminalSingleDuctInletSideMixer> terminal;

if (boost::optional<ModelObject> outlet = node.outletModelObject()) {

if (boost::optional<PortList> pl = outlet->optionalCast<PortList>()) {

thermalZone = pl->thermalZone();

}

}

if (boost::optional<ModelObject> inlet = node.inletModelObject()) {

terminal = inlet->optionalCast<AirTerminalSingleDuctInletSideMixer>();

}

if (thermalZone && terminal) {

jmarrec · 2024-12-24T08:20:07Z

src/model/ZoneHVACEvaporativeCoolerUnit.cpp

+      return std::move(evaporativeCoolUnitClone);
+    }
+
+    std::vector<IdfObject> ZoneHVACEvaporativeCoolerUnit_Impl::remove() {


Could consider using #include "../utilities/core/ContainersMove.hpp", eg

OpenStudio/src/model/Building.cpp

Line 122 in 0314c3e

openstudio::detail::concat_helper(result, ParentObject_Impl::remove());

Also, given the way you wrote the children() method, I'm not sure explicitly cloning the children is necessary, but I could be wrong. In the end, I only care if the (future) test shows everything works as expected.

src/model/ZoneHVACEvaporativeCoolerUnit.cpp

jmarrec · 2024-12-24T08:29:18Z

src/osversion/VersionTranslator.cpp

Why is there a (clang-format) diff here?

jmarrec · 2024-12-24T08:31:24Z

src/energyplus/ForwardTranslator/ForwardTranslateZoneHVACEvaporativeCoolerUnit.cpp

+    // Outdoor Air Inlet Node Name: Required Node
+    if (boost::optional<Node> node = modelObject.inletNode()) {


Do/should we catch the case where it's somehow not set?

src/energyplus/ForwardTranslator/ForwardTranslateZoneHVACEvaporativeCoolerUnit.cpp

jmarrec · 2025-01-06T08:53:52Z

The following tests FAILED:
	2756 - ModelFixture.ZoneHVACEvaporativeCoolerUnit_clone (Failed)
	2757 - ModelFixture.ZoneHVACEvaporativeCoolerUnit_remove (Failed)
	2758 - ModelFixture.ZoneHVACEvaporativeCoolerUnit_addToNode (Failed)

joseph-robertson · 2025-01-06T16:53:08Z

src/model/test/ZoneHVACEvaporativeCoolerUnit_GTest.cpp

+  EXPECT_FALSE(zonehvac.remove().empty());
+  EXPECT_EQ(size - 1, m.modelObjects().size());


I'm not really sure what remove is actually supposed to remove. Looks like, without an override, it currently removes more than just the ZoneHVACEvaporativeCoolerUnit...?

Remove is supposed to remove the children - that aren't resource objects - and their recursive children as well as the ZoneHVACEvaporativeCoolerUnit.

ZoneHVACEvaporativeCoolerUnit is a ZoneHVACComponent > HVACComponent > ParentObject

Eventually this is what's called.

OpenStudio/src/model/ParentObject.cpp

Lines 44 to 72 in 0314c3e

/// remove self and all children objects recursively

std::vector<IdfObject> ParentObject_Impl::remove() {

std::vector<IdfObject> result;

// DLM: the following code does not work because subTree includes this object

// and we don't want to call remove on the same object recursively

//

//ModelObjectVector subTree = getRecursiveChildren(getObject<ParentObject>());

//for (ModelObject& object : subTree) {

// std::vector<IdfObject> removed = object.remove();

// result.insert(result.end(), removed.begin(), removed.end());

//}

// subTree includes this object, make sure to include costs as well

// drop the ResourceObject instances, if they are used by other objects

// This is probably the unique situation where you want to get children minus ResourceObjects

auto subTree = getRecursiveChildren(getObject<ParentObject>(), true, false);

result.reserve(subTree.size());

for (const ModelObject& object : subTree) {

result.emplace_back(object.idfObject());

}

bool ok = model().removeObjects(getHandles<ModelObject>(subTree));

if (!ok) {

result.clear();

}

return result;

}

i'm building your PR locally, will check out the tests in a bit

jmarrec · 2025-01-07T16:13:46Z

src/model/ZoneHVACEvaporativeCoolerUnit.hpp

+
+    Schedule availabilitySchedule() const;
+
+    HVACComponent supplyAirFan() const;


All fans need an addition to their containingZoneHVACComponent

This is used in particular to check if the HVACComponent::isRemovable when remove() is called.

jmarrec · 2025-01-07T16:18:51Z

src/model/ZoneHVACEvaporativeCoolerUnit.hpp

+
+    double coolingLoadControlThresholdHeatTransferRate() const;
+
+    HVACComponent firstEvaporativeCooler() const;


SAme comment

There are five types of evaporative cooler component models to choose from: EvaporativeCooler:Direct:CelDekPad, EvaporativeCooler:Direct:ResearchSpecial, EvaporativeCooler:Indirect:CelDekPad, EvaporativeCooler:Indirect:WetCoil, or EvaporativeCooler:Indirect:ResearchSpecial.

For us that's EvaporativeCoolerDirectResearchSpecial and EvaporativeCoolerIndirectResearchSpecial

…ponent` #5326 (comment)

… models `containingZoneHVACComponent` cf #5326 (comment)

jmarrec · 2025-01-07T16:49:37Z

@joseph-robertson I made adjustments: https://github.com/NREL/OpenStudio/pull/5326/files/4cb656d678a376bb72010aacce41d44eefd03c47..bbbda1d885418e99ff57e9094f8803acda1ceab2

You'll need to add an OpenStudio-resources test for this object and add it to the top post's checklist please

…ponent` #5326 (comment)

… models `containingZoneHVACComponent` cf #5326 (comment)

jmarrec · 2025-01-09T12:56:46Z

resources/model/OpenStudio.idd

+       \object-list SystemAvailabilityManagerLists
+  A5,  \field Outdoor Air Inlet Node Name
+       \required-field
+       \type object-list
+       \object-list ConnectionNames
+       \note this is an outdoor air node
+  A6,  \field Cooler Outlet Node Name
+       \required-field
+       \type object-list
+       \object-list ConnectionNames
+       \note this is a zone inlet node
+  A7,  \field Zone Relief Air Node Name
+       \type object-list
+       \object-list ConnectionNames
+       \note this is a zone exhaust node, optional if flow is being balanced elsewhere


Ok, I think the node connections are wrong at model namespace.

You've set inletPort to be "Outdoor Air Inlet Node Name", but that should be an OA node. And I don't think it should be in the IDD, or at least it should just be a std::string (alpha) one.

inletPort should be Zone Relief Air Node Name, so that the addToThermalZone works

Zone Relief Air Node Name : This optional alpha input field defines the name of an HVAC system node which can extract air from the zone to balance the air supplied to the zone by the cooler outlet node. This node name would match the name of a zone exhaust air node.

. But we should also have a Boolean field like "Flow Is Balanced" to determine whether we write it to IDF or not (or maybe we just always assume it is balanced here, not elsewhere)

Proposed a change in 373c394

That comment stands though:

But we should also have a Boolean field like "Flow Is Balanced" to determine whether we write it to IDF or not (or maybe we just always assume it is balanced here, not elsewhere)

cf #5326 (comment)

…ponent` #5326 (comment)

… models `containingZoneHVACComponent` cf #5326 (comment)

cf #5326 (comment)

jmarrec · 2025-01-16T11:43:48Z

src/model/ZoneHVACEvaporativeCoolerUnit.cpp

+    boost::optional<double> ZoneHVACEvaporativeCoolerUnit_Impl::autosizedDesignSupplyAirFlowRate() {
+      return getAutosizedValue("TODO_CHECK_SQL Design Supply Air Flow Rate", "m3/s");
+    }


TODO. Found after correctly adding the object to autosize_hvac.rb in OS-res PR

…sor node

jmarrec · 2025-01-16T14:40:16Z

src/energyplus/ForwardTranslator/ForwardTranslateZoneHVACEvaporativeCoolerUnit.cpp

+    HVACComponent firstEvaporativeCooler = modelObject.firstEvaporativeCooler();
+    boost::optional<IdfObject> firstEvaporativeCooler_ = translateAndMapModelObject(firstEvaporativeCooler);


The naming of these variables is terribly confusing. More on this in a minute.

jmarrec · 2025-01-16T14:40:49Z

src/energyplus/ForwardTranslator/ForwardTranslateZoneHVACEvaporativeCoolerUnit.cpp

+        outletNodeName = baseName + " First Evaporative Cooler - Fan Node";
+      }
+
+      if (firstEvaporativeCooler_->iddObject().type() == IddObjectType::EvaporativeCooler_Direct_ResearchSpecial) {


Checking the type of the IdfObject...

jmarrec · 2025-01-16T14:42:59Z

src/energyplus/ForwardTranslator/ForwardTranslateZoneHVACEvaporativeCoolerUnit.cpp

+        firstEvaporativeCooler_->setString(EvaporativeCooler_Direct_ResearchSpecialFields::AirInletNodeName, inletNodeName);
+        firstEvaporativeCooler_->setString(EvaporativeCooler_Direct_ResearchSpecialFields::AirOutletNodeName, outletNodeName);
+        firstEvaporativeCooler_->setString(EvaporativeCooler_Direct_ResearchSpecialFields::SensorNodeName, outletNodeName);
+      } else if (firstEvaporativeCooler.iddObject().type() == IddObjectType::EvaporativeCooler_Indirect_ResearchSpecial) {


UH OH. Checking the type of the Modelobject!!! Which is "OS:xxxx" and WILL NOT MATCH.

I revamped the OS-resources test to flip the order of the Indirect and Direct evap cooler so it's similar to https://github.com/NREL/EnergyPlus/blob/31e3c33467c5873371bf48b12a7318215971c315/testfiles/StripMallZoneEvapCoolerAutosized.idf#L4767-L4784

And I was getting empty nodes, and I couldn't figure out why. I just noticed this only after completely rewrittign the FT routine...

jmarrec · 2025-01-16T14:46:05Z

src/energyplus/ForwardTranslator/ForwardTranslateZoneHVACEvaporativeCoolerUnit.cpp

+    boost::optional<HVACComponent> _secondEvaporativeCooler = modelObject.secondEvaporativeCooler();
+    boost::optional<IdfObject> secondEvaporativeCooler_;


I think that's my favourite :) leading versus trailing "_"

…e OS:XXX object This is now impossible to do because I've scoped the variable.

cf NREL/OpenStudio-resources#215 (comment)

…me" being always filled out

jmarrec · 2025-01-16T16:38:50Z

developer/doc/ReleaseNotes/OpenStudio_Release_Notes_3_9_1_TDB.md

+* [#5326](https://github.com/NREL/OpenStudio/pull/5326) - Wrap ZoneHVAC:EvaporativeCoolerUnit
+    * The object was wrapped in the SDK.
+    * Note: in EnergyPlus 24.2.0, the `Zone Relief Air Node Name` is an optional field. The OpenStudio SDK always fills with the connected zone's Exhaust Air Node, meaning the airflow is always being balanced by EnergyPlus: the object will extract air from the zone to balance the air supplied to the zone by the cooler outlet node.


Add a note in the TDB release notes

ci-commercialbuildings · 2025-01-17T18:45:40Z

CI Results for f8c27b8:

Ubuntu 24.04:
- OpenStudio-3.9.1-alpha+f8c27b85a2-Ubuntu-24.04-x86_64.deb
- OpenStudio-3.9.1-alpha+f8c27b85a2-Ubuntu-24.04-x86_64.tar.gz
Ubuntu 22.04:
Darwin:
- OpenStudio-3.9.1-alpha+f8c27b85a2-Darwin-x86_64.dmg
- OpenStudio-3.9.1-alpha+f8c27b85a2-Darwin-x86_64.tar.gz
Windows:
- OpenStudio-3.9.1-alpha+f8c27b85a2-Windows.exe
- OpenStudio-3.9.1-alpha+f8c27b85a2-Windows.tar.gz
Code Coverage:

joseph-robertson added Enhancement Request component - HVAC Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. IDDChange labels Dec 18, 2024

joseph-robertson self-assigned this Dec 18, 2024

jmarrec requested changes Dec 19, 2024

View reviewed changes

jmarrec requested changes Dec 24, 2024

View reviewed changes

joseph-robertson commented Jan 6, 2025

View reviewed changes

joseph-robertson marked this pull request as ready for review January 6, 2025 18:48

joseph-robertson requested a review from jmarrec January 6, 2025 18:48

jmarrec reviewed Jan 7, 2025

View reviewed changes

jmarrec added a commit that referenced this pull request Jan 7, 2025

Add ZoneHVACEvaporativeCoolerUnit to all Fan's `containingZoneHVACCom…

0cd17fc

…ponent` #5326 (comment)

jmarrec added a commit that referenced this pull request Jan 7, 2025

Add ZoneHVACEvaporativeCoolerUnit to all evaporative cooler component…

194a51b

… models `containingZoneHVACComponent` cf #5326 (comment)

joseph-robertson mentioned this pull request Jan 7, 2025

Wrap ZoneHVAC:EvaporativeCoolerUnit NREL/OpenStudio-resources#215

Open

26 tasks

jmarrec added a commit that referenced this pull request Jan 9, 2025

Add ZoneHVACEvaporativeCoolerUnit to all Fan's `containingZoneHVACCom…

3d15a25

…ponent` #5326 (comment)

jmarrec added a commit that referenced this pull request Jan 9, 2025

Add ZoneHVACEvaporativeCoolerUnit to all evaporative cooler component…

25ff3d2

… models `containingZoneHVACComponent` cf #5326 (comment)

jmarrec force-pushed the zonehvac-evap-cooler branch from bbbda1d to 292a5d4 Compare January 9, 2025 12:32

jmarrec requested changes Jan 9, 2025

View reviewed changes

jmarrec added a commit that referenced this pull request Jan 9, 2025

Adjust node connections

373c394

cf #5326 (comment)

joseph-robertson added 9 commits January 15, 2025 10:16

Add ZoneHVAC:EvaporativeCoolerUnit to idd.

bc6477d

Update the new idd entry.

26b5f56

First add of model, ft, and test files.

5045e19

Update model resource files.

40983fa

Update nodes in ft, general cleanup.

70dff3b

Fix and improve model and ft tests.

7fb2a46

Add tests and clean up cpp and ft.

9fc6562

Fix ft and tests.

1b3315e

Remove remove override and update tests.

985ffd7

jmarrec added 5 commits January 15, 2025 10:16

Add ZoneHVACEvaporativeCoolerUnit to all Fan's `containingZoneHVACCom…

b9800aa

…ponent` #5326 (comment)

Add ZoneHVACEvaporativeCoolerUnit to all evaporative cooler component…

3713357

… models `containingZoneHVACComponent` cf #5326 (comment)

Improve and fixup tests

c6b3eeb

Write Sensor Node Name (do we need to write relief air Node name?)

d5d632a

Adjust node connections

d805651

cf #5326 (comment)

jmarrec force-pushed the zonehvac-evap-cooler branch from 373c394 to d805651 Compare January 15, 2025 09:16

clang-format

86afadc

jmarrec requested changes Jan 16, 2025

View reviewed changes

jmarrec added 2 commits January 16, 2025 12:43

Implement autosizedDesignSupplyAirFlowRate correclty

c969110

Always use the ZoneHVACEvaporativeCoolerUnit's outlet node as the Sen…

66a2f6c

…sor node

jmarrec requested changes Jan 16, 2025

View reviewed changes

jmarrec reviewed Jan 16, 2025

View reviewed changes

jmarrec added 4 commits January 16, 2025 15:48

Rewrite the FT and fix the issue where it was checking the type of th…

2477a80

…e OS:XXX object This is now impossible to do because I've scoped the variable.

Fix Severe Node Connection error

73365b1

cf NREL/OpenStudio-resources#215 (comment)

Adjust FT test after node connections got fixed

d3e1fe9

Add a TDB 3.9.1 release notes to mention the "Zone Relief Air Node Na…

b9e6f0e

…me" being always filled out

jmarrec reviewed Jan 16, 2025

View reviewed changes

joseph-robertson added 3 commits January 17, 2025 09:53

Change ctor to fansystemmodel, and update some tests.

65526d3

Fix ft test after ctor fan change.

b510cdd

Fix FT test.

f8c27b8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wrap ZoneHVAC:EvaporativeCoolerUnit #5326

Wrap ZoneHVAC:EvaporativeCoolerUnit #5326

joseph-robertson commented Dec 18, 2024 •

edited by jmarrec

Loading

jmarrec Dec 19, 2024

jmarrec Dec 19, 2024

jmarrec left a comment

jmarrec Dec 24, 2024

jmarrec Dec 24, 2024

jmarrec Dec 24, 2024

jmarrec Dec 24, 2024

jmarrec Dec 24, 2024

jmarrec commented Jan 6, 2025

joseph-robertson Jan 6, 2025

jmarrec Jan 7, 2025

jmarrec Jan 7, 2025

jmarrec Jan 7, 2025

jmarrec Jan 7, 2025

jmarrec Jan 7, 2025

jmarrec Jan 7, 2025

jmarrec commented Jan 7, 2025 •

edited

Loading

jmarrec Jan 9, 2025 •

edited

Loading

jmarrec Jan 9, 2025

jmarrec Jan 15, 2025

jmarrec Jan 16, 2025 •

edited

Loading

jmarrec Jan 16, 2025

jmarrec Jan 16, 2025

jmarrec Jan 16, 2025

jmarrec Jan 16, 2025

jmarrec Jan 16, 2025

jmarrec Jan 16, 2025

ci-commercialbuildings commented Jan 17, 2025 •

edited

Loading

	bool ZoneHVACComponent_Impl::addToNode(Node& node) {
	bool result = false;

	boost::optional<ThermalZone> thermalZone;
	boost::optional<AirTerminalSingleDuctInletSideMixer> terminal;

	if (boost::optional<ModelObject> outlet = node.outletModelObject()) {
	if (boost::optional<PortList> pl = outlet->optionalCast<PortList>()) {
	thermalZone = pl->thermalZone();
	}
	}

	if (boost::optional<ModelObject> inlet = node.inletModelObject()) {
	terminal = inlet->optionalCast<AirTerminalSingleDuctInletSideMixer>();
	}

	if (thermalZone && terminal) {

		// Outdoor Air Inlet Node Name: Required Node
		if (boost::optional<Node> node = modelObject.inletNode()) {

		EXPECT_FALSE(zonehvac.remove().empty());
		EXPECT_EQ(size - 1, m.modelObjects().size());

	/// remove self and all children objects recursively
	std::vector<IdfObject> ParentObject_Impl::remove() {
	std::vector<IdfObject> result;

	// DLM: the following code does not work because subTree includes this object
	// and we don't want to call remove on the same object recursively
	//
	//ModelObjectVector subTree = getRecursiveChildren(getObject<ParentObject>());
	//for (ModelObject& object : subTree) {
	// std::vector<IdfObject> removed = object.remove();
	// result.insert(result.end(), removed.begin(), removed.end());
	//}

	// subTree includes this object, make sure to include costs as well
	// drop the ResourceObject instances, if they are used by other objects
	// This is probably the unique situation where you want to get children minus ResourceObjects
	auto subTree = getRecursiveChildren(getObject<ParentObject>(), true, false);
	result.reserve(subTree.size());
	for (const ModelObject& object : subTree) {
	result.emplace_back(object.idfObject());
	}

	bool ok = model().removeObjects(getHandles<ModelObject>(subTree));
	if (!ok) {
	result.clear();
	}

	return result;
	}


		Schedule availabilitySchedule() const;

		HVACComponent supplyAirFan() const;


		double coolingLoadControlThresholdHeatTransferRate() const;

		HVACComponent firstEvaporativeCooler() const;

		HVACComponent firstEvaporativeCooler = modelObject.firstEvaporativeCooler();
		boost::optional<IdfObject> firstEvaporativeCooler_ = translateAndMapModelObject(firstEvaporativeCooler);

		boost::optional<HVACComponent> _secondEvaporativeCooler = modelObject.secondEvaporativeCooler();
		boost::optional<IdfObject> secondEvaporativeCooler_;

Wrap ZoneHVAC:EvaporativeCoolerUnit #5326

Are you sure you want to change the base?

Wrap ZoneHVAC:EvaporativeCoolerUnit #5326

Conversation

joseph-robertson commented Dec 18, 2024 • edited by jmarrec Loading

Pull request overview

Pull Request Author

Review Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmarrec left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmarrec commented Jan 6, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmarrec commented Jan 7, 2025 • edited Loading

jmarrec Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmarrec Jan 16, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ci-commercialbuildings commented Jan 17, 2025 • edited Loading

joseph-robertson commented Dec 18, 2024 •

edited by jmarrec

Loading

jmarrec commented Jan 7, 2025 •

edited

Loading

jmarrec Jan 9, 2025 •

edited

Loading

jmarrec Jan 16, 2025 •

edited

Loading

ci-commercialbuildings commented Jan 17, 2025 •

edited

Loading