Publish package to JSR in addition to npm. #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theengineear
force-pushed
the
publish-to-jsr
branch
from
c44297a to
c1150a3
Compare
theengineear
commented
Feb 29, 2024
| - run: npm ci | ||
| # Can we get this to use “deno publish”? | ||
| # - run: deno publish | ||
| - run: npx jsr publish |
There was a problem hiding this comment.
Using npx because it exists without need for additional install. I think using deno in the future would be neat though.
theengineear
force-pushed
the
publish-to-jsr
branch
from
c1150a3 to
3fe31b6
Compare
theengineear
commented
Feb 29, 2024
| # Bump version in package.json using npm version itself. This ensures that we | ||
| # stay anchored to first-class tooling. We pass “--git-tag-version=false” to | ||
| # prevent the command from (1) committing changes and (2) creating a tag. | ||
| prefixed_version="$(npm version --git-tag-version=false "${1}")" |
There was a problem hiding this comment.
This is critical – note that we are 100% passing exactly the value to the real npm version command here. This means that running npm version patch (or some such) will just work. It also means that if you try to provide the same version or something, it’ll fail with a human-readable error message.
theengineear
force-pushed
the
publish-to-jsr
branch
from
3fe31b6 to
b2f480c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks our publish flow to publish both to npm and JSR with the same version (what we want). Note that care is take to wrap the
npm versioncommand so that we still use this first-class command as our anchor for bumping our version.