-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish package to JSR in addition to npm. #174
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# Publish package to JSR. | ||
name: Publish to JSR | ||
on: [workflow_call] | ||
jobs: | ||
main: | ||
runs-on: ubuntu-latest | ||
permissions: | ||
contents: read | ||
id-token: write | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-node@v3 | ||
with: | ||
node-version: '20.x' | ||
registry-url: 'https://registry.npmjs.org' | ||
- run: npm ci | ||
# Can we get this to use “deno publish”? | ||
# - run: deno publish | ||
- run: npx jsr publish | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
#!/bin/bash | ||
|
||
# Wrapper around “npm version” which appends additional logic to also update the | ||
# “deno.json” file which controls how we publish to JSR. | ||
|
||
# Exit upon any failure. I.e., make script strictly sequential. | ||
set -e | ||
|
||
# Print current version information. | ||
npm version | ||
|
||
# Bail if we don’t have a version string for some reason. This is not an error. | ||
if [ -z "${1}" ] | ||
then | ||
exit 0 | ||
fi | ||
|
||
# Bump version in package.json using npm version itself. This ensures that we | ||
# stay anchored to first-class tooling. We pass “--git-tag-version=false” to | ||
# prevent the command from (1) committing changes and (2) creating a tag. | ||
prefixed_version="$(npm version --git-tag-version=false "${1}")" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is critical – note that we are 100% passing exactly the value to the real |
||
|
||
# The “npm version” command will return the value with a “v” prefix. Ditch that. | ||
version="${prefixed_version:1}" | ||
|
||
# Get pointers to files we need to manually update. | ||
root_directory="$(dirname "$(realpath "${0}")")" | ||
deno_json_file="${root_directory}/deno.json" | ||
package_json_file="${root_directory}/package.json" | ||
package_lock_json_file="${root_directory}/package-lock.json" | ||
|
||
# Bump version in deno.json. | ||
deno_json_find="\"version\": \"[^\"]*\"" | ||
deno_json_repl="\"version\": \"${version}\"" | ||
next_deno_json_file=$(sed "s/${deno_json_find}/${deno_json_repl}/g" "${deno_json_file}") | ||
echo "updating \"${deno_json_file}\"" | ||
echo "${next_deno_json_file}" > "${deno_json_file}" | ||
|
||
# Commit all our changes. | ||
git add "${package_json_file}" | ||
git add "${package_lock_json_file}" | ||
git add "${deno_json_file}" | ||
git commit --message="${version}" | ||
git tag --annotate "v${version}" --message="${version}" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"name": "@netflix/x-element", | ||
"version": "1.0.0-rc.58", | ||
"exports": "./x-element.js" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
npx
because it exists without need for additional install. I think usingdeno
in the future would be neat though.