Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove staging area functionality #97

Merged
merged 3 commits into from
Sep 24, 2024
Merged

remove staging area functionality #97

merged 3 commits into from
Sep 24, 2024

Conversation

magland
Copy link
Collaborator

@magland magland commented Sep 20, 2024

@rly as we discussed, this removes all staging area functionality because this is now replaced by the writeable .lindi.tar and .lindi.d formats.

Also removed the File() class which was supposed to be a drop-in replacement for h5py.File including writing to a staging area.

Also removed the upload() capability. That should be handled separately, IMO.

Delete LindiStagingStore functionality
@magland magland requested a review from rly September 20, 2024 11:23
Remove test_lindi_file.py unit test
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.13%. Comparing base (9183af9) to head (9e11c34).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   69.07%   67.13%   -1.95%     
==========================================
  Files          34       30       -4     
  Lines        3046     2796     -250     
==========================================
- Hits         2104     1877     -227     
+ Misses        942      919      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oruebel
Copy link

oruebel commented Sep 20, 2024

Also removed the File() class which was supposed to be a drop-in replacement for h5py.File including writing to a staging area.

Just wanted to clarify, is this the same as the h5py.File type class that is being used for reading from HDF5 files or is this a separate class that was used just for writing data to a staging area?

@magland
Copy link
Collaborator Author

magland commented Sep 20, 2024

Also removed the File() class which was supposed to be a drop-in replacement for h5py.File including writing to a staging area.

Just wanted to clarify, is this the same as the h5py.File type class that is being used for reading from HDF5 files or is this a separate class that was used just for writing data to a staging area?

It's confusing, sorry. The primary class for reading hdf5 files in lindi (and doing other manipulations) is LindiH5pyFile which inherits h5py.File for compatibility purposes. This lindi.File that is being removed was different. It was supposed to be a drop-in replacement for h5py.File for both reading and writing with a staging area. But now that staging area is going away and there is a different mechanism for writing, this lindi.File needs to disappear as well. Hopefully with its demise the confusion will end here. :)

@oruebel
Copy link

oruebel commented Sep 20, 2024

Hopefully with its demise the confusion will end here. :)

That makes sense. Thank you for the clarification 👍

@rly
Copy link
Contributor

rly commented Sep 23, 2024

Looks good to me!

@magland magland merged commit 5ee481b into main Sep 24, 2024
6 checks passed
@magland magland deleted the remove-staging-area branch September 24, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants