-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove staging area functionality #97
Conversation
Delete LindiStagingStore functionality
Remove test_lindi_file.py unit test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
- Coverage 69.07% 67.13% -1.95%
==========================================
Files 34 30 -4
Lines 3046 2796 -250
==========================================
- Hits 2104 1877 -227
+ Misses 942 919 -23 ☔ View full report in Codecov by Sentry. |
Just wanted to clarify, is this the same as the |
It's confusing, sorry. The primary class for reading hdf5 files in lindi (and doing other manipulations) is LindiH5pyFile which inherits h5py.File for compatibility purposes. This lindi.File that is being removed was different. It was supposed to be a drop-in replacement for h5py.File for both reading and writing with a staging area. But now that staging area is going away and there is a different mechanism for writing, this lindi.File needs to disappear as well. Hopefully with its demise the confusion will end here. :) |
That makes sense. Thank you for the clarification 👍 |
Looks good to me! |
@rly as we discussed, this removes all staging area functionality because this is now replaced by the writeable .lindi.tar and .lindi.d formats.
Also removed the File() class which was supposed to be a drop-in replacement for h5py.File including writing to a staging area.
Also removed the upload() capability. That should be handled separately, IMO.