Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart.rhttp: init #354410

Closed
wants to merge 1 commit into from
Closed

dart.rhttp: init #354410

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 8, 2024 •
edited by ghost
Loading

  • Initialize dart.rhttp. The rhttp package is required by packages like localsend, and it needs to be overridden for proper functionality.
  • rhttp: Make HTTP requests using Rust from Flutter. https://github.com/Tienisto/rhttp

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ghost ghost force-pushed the dart-rhttp branch from 2148a51 to e65827e Compare November 8, 2024 06:29
@ghost ghost marked this pull request as ready for review November 8, 2024 06:30
@ghost ghost requested a review from Aleksanaa November 8, 2024 06:33
This was referenced Nov 8, 2024
Merged
Closed
@ghost ghost force-pushed the dart-rhttp branch from e65827e to bb4c4f0 Compare November 8, 2024 07:13
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 8, 2024
@ghost ghost force-pushed the dart-rhttp branch from bb4c4f0 to 02b9cea Compare November 8, 2024 13:36
@ghost ghost marked this pull request as draft November 8, 2024 13:39
@ghost ghost force-pushed the dart-rhttp branch from 02b9cea to ecd983c Compare November 8, 2024 13:46
@ghost ghost marked this pull request as ready for review November 8, 2024 13:47
@ghost ghost force-pushed the dart-rhttp branch from ecd983c to b54fda2 Compare November 8, 2024 18:14
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4812

@KiaraGrouwstra
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354410

@KiaraGrouwstra
Copy link
Contributor

nixpkgs-review on x86_64-linux isn't seeing the package for me somehow, not sure why

@Aleksanaa
Copy link
Member

We'd rather use that PR instead, because we cannot review this one.

@Aleksanaa Aleksanaa closed this Nov 11, 2024
@ghost ghost deleted the dart-rhttp branch November 12, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nixos-discourse @KiaraGrouwstra @Aleksanaa