[16.0][MIG] l10n_eu_nace new ShowVoc integration #196

edlopen · 2024-04-15T19:19:34Z

Hello you all,

this is a migration and a refactor of the l10n_eu_nace module. Since the RAMON servers from we get te csv data are deprecated this PR contains the functionality to get the data directly from the new ShowVoc web catalogue in the format of a SPARQL endpoint. This get the industries and their translation by a API request and by running a simple wizard.

I would appreciate that this PR is merged rather quickly as it's my intention to migrate similar modules that relays on this new ShowVoc dataset.

Also I included this stale PR's commit.

@moduon MT-1816

@yajo @EmilioPascual @Shide @rafaelbn review this PR when you can.

…anslations

Short category names are now displayed on partner views, since NACE names are so long

Data files were there, but translations were not.

[ADD] setup.py

[12.0][IMP] - Add unit tests [IMP] - code improve Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/migrations/12.0.2.0.0/pre-migration.py Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/migrations/12.0.2.0.0/post-migration.py Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/models/res_partner_nace.py Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/models/res_partner_nace.py Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/models/res_partner_nace.py Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/models/res_partner_nace.py Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/models/res_partner.py Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/models/res_partner_nace.py Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/views/res_partner.xml Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/readme/CONTRIBUTORS.rst Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/models/res_partner_nace.py Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/models/res_partner_nace.py Co-authored-by: Jairo Llopis <[email protected]> [FIX] - fix code Update l10n_eu_nace/models/res_partner_nace.py Co-authored-by: Jairo Llopis <[email protected]> [FIX] - Fix name_search

Fix post-migration Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/models/res_partner_nace.py Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/models/res_partner_nace.py Co-authored-by: Jairo Llopis <[email protected]>

Some need to add secondary NACE codes to partners. This is a very little addition, possibly quite standard, so it's done directly in the base addon. @Tecnativa TT17678

FIX + IMP : more readable query for updating partners with new xml_id regarding old xml_id

vincent-hatakeyama · 2024-04-16T09:30:18Z

I’ve just tested the module.

The wizard need rework. There’s a save/discard button on the bottom and in the centre a big Import button. The import button need to replace the save button, and in the middle a text indicating what would happen would be best.

The import is fast. After import, the list of industries is not shown, so it feels like it did not work. I expected the list of industries to be shown again.

Importing again works as expected. If a language is added, the wizard needs to be run again. It should be indicated in the readme, or automatically done when a new language is activated.

I was also surprised that the module did not run the import during installation.

Odoo SA split the name and full name, only adding the code in the full name. I expected this module to do the same.

The list of industries is also strangely sorted, but I think that has nothing to do with this module.

EmilioPascual

Thank you @edlopen for this pr. Some changes.

EmilioPascual · 2024-04-16T07:57:59Z

l10n_eu_nace/readme/USAGE.rst

+NACE Wizard. This will search for all active languages in Odoo and import the
+data for each one.
+
+1. Go to "Contacts" > "Configuration" > "Import NACE Wizard"


Suggested change

1. Go to "Contacts" > "Configuration" > "Import NACE Wizard"

1. Go to "Contacts" > "Configuration" > "Import NACE industries"

EmilioPascual · 2024-04-16T09:37:57Z

l10n_eu_nace/wizard/res_partner_industry_eu_nace_wizard_view.xml

+            <form string="Import NACE industries">
+                <sheet>
+                    <group>
+                        <button


Maybe the button should be in the footer. Also, in the sheet it would be nice to put an informative text.

l10n_eu_nace/wizard/res_partner_industry_eu_nace_wizard.py

EmilioPascual · 2024-04-16T09:54:01Z

l10n_eu_nace/wizard/res_partner_industry_eu_nace_wizard.py

+        bindings = nace_json.get("results", {}).get("bindings", {})
+        for binding in bindings:
+            nace_code = binding.get("code", {}).get("value", "")
+            nace_id = self.env["res.partner.industry"].search(


A search in a for can be a bottleneck. You could map them earlier.

Done! Thanks for your review @EmilioPascual

aronabencherif · 2024-04-16T12:59:08Z

@edlopen thanks already for this PR. I just reviewed all your code and I honestly admit that yours is much better. However, following the same logic as @vincent-hatakeyama, in Odoo's code base the full name is obtained by combining the code and the name. And what's more, once you have imported the data, you have the impression that nothing happens afterwards, no popup to explain that your code works perfectly 😀 and no list either to display the imported data. 👍

yajo

Absolutely amazing!

Some comments though.

yajo · 2024-04-17T12:40:18Z

l10n_eu_nace/__manifest__.py

-    "depends": ["contacts"],
+    "maintainers": ["rafaelbn", "yajo", "edlopen"],
+    "depends": ["partner_industry_secondary"],
+    "external_dependencies": {"python": ["requests"]},


suggestion: remove this implicit dependency, as Odoo 16 already requires it.

yajo · 2024-04-17T12:41:28Z

l10n_eu_nace/readme/USAGE.rst

-    http://ec.europa.eu/eurostat/ramon/nomenclatures/index.cfm?TargetUrl=LST_CLS_DLD&StrNom=NACE_REV2&StrLanguageCode=FR&StrLayoutCode=#
+If you want to import or update the data, you can do so by running the Import
+NACE Wizard. This will search for all active languages in Odoo and import the
+data for each one.


Suggested change

data for each one.

data for each one. If you activate a new language, remember to run this wizard again.

yajo · 2024-04-17T12:43:32Z

l10n_eu_nace/tests/test_res_partner_industry_eu_nace_wizard.py

+        import_wizard = wizard.save()
+        return import_wizard
+
+    @users("test-manager")


suggestion: You can remove this decorator, if you follow my suggestion above in setUpClass. The same applies for all other uses of @users

yajo · 2024-04-17T12:44:44Z

l10n_eu_nace/tests/test_res_partner_industry_eu_nace_wizard.py

+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.user = new_test_user(


suggestion: change this to implicitly change the tests env from here onwards:

Suggested change

cls.user = new_test_user(

cls.uid = new_test_user(

Done! Thanks for your review @yajo

edlopen · 2024-04-19T09:22:34Z

@vincent-hatakeyama @aronabencherif I've updated the wizard and now after installation the import wizard will appear. Also the names and full names are different, with the full names being the code and the nace name. Finally, after running the wizard, the industry tree view is displayed.

I hope this make the module more clear and easy to use. Thank you for your reviews!

yajo

l10n_eu_nace/readme/USAGE.rst

Co-authored-by: Jairo Llopis <[email protected]>

rafaelbn

Great job! Thank you!

OCA-git-bot · 2024-04-22T11:36:42Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

yajo · 2024-04-22T12:38:33Z

/ocabot merge patch

OCA-git-bot · 2024-04-22T12:39:19Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-196-by-yajo-bump-patch, awaiting test results.

OCA-git-bot · 2024-04-22T12:44:45Z

Congratulations, your PR was merged at 86a5f9a. Thanks a lot for contributing to OCA. ❤️

edlopen · 2024-04-23T08:20:23Z

I forgot to add a migration script so that the data is not lost from the res.partner. Currently working to add it in a separate issue and PR.

Thank you all.

Numerigraphe - Lionel Sausin and others added 30 commits October 28, 2023 12:01

[ADD] l10n_eu_nace: add European Union statistical partner categories

18bf550

[IMP] l10n_eu_nace: let users search for NACE codes ommiting the "."

57fbeb4

[REF] Cosmetics

d9b648b

[IMP] l10n_eu_nace: generate .pot file along with translations

51cbdfb

[FIX] l10n_eu_nace used country codes instead of language codes in tr…

c97b682

…anslations

[IMP] Update to v7.0 coding standard

5338ede

[IMP] PEP8

50cc24f

move addons to __unported__

be95bea

[IMP] ported l10n_eu_nace to v8

30e9237

Short category names are now displayed on partner views, since NACE names are so long

[UPD] prefix versions with 8.0

0c1c7b7

[MIG] Make modules uninstallable

a2d7dd6

Port l10n_eu_nace to v9

13bb0f4

Migrate to new api

d91c1cd

Finalize migration to new api

2215ffd

Fix pep8

dab8f66

remove +x flag on partner.py

dec115e

[MIG] Make modules uninstallable

76d7a49

[MIG] Rename manifest files

aa4ccb9

[MIG] l10n_eu_nace : Migrated to 10.0

2cdc575

[FIX][l10n_eu_nace] Add missing languages.

4c87264

Data files were there, but translations were not.

remove obsolete .pot files [ci skip]

0c7d07f

[MIG] - migration l10n_eu_nace to 12.0

d5c7b94

[ADD] setup.py

[FIX] - use computed name for complete name

5a4f160

[IMP] - make short name as default

cc5756b

[RMV] - remove broken files

d07a9b7

[IMP] l10n_eu_nace: add secondary

fc654a8

Some need to add secondary NACE codes to partners. This is a very little addition, possibly quite standard, so it's done directly in the base addon. @Tecnativa TT17678

FIX : Bad type in pre migration with boolean attribute

36b2d9d

FIX + IMP : more readable query for updating partners with new xml_id regarding old xml_id

FIX Pylint

2844157

edlopen mentioned this pull request Apr 15, 2024

Improve migration 16.0 l10n eu nace #195

Closed

Merge branch '16.0' into 16.0-mig-l10n_eu_nace

7c8708d

EmilioPascual suggested changes Apr 16, 2024

View reviewed changes

yajo requested changes Apr 17, 2024

View reviewed changes

edlopen force-pushed the 16.0-mig-l10n_eu_nace branch from 9862788 to 83c94c1 Compare April 19, 2024 07:24

[16.0][MIG] l10n_ue_nace PR upgrades

42e2788

edlopen force-pushed the 16.0-mig-l10n_eu_nace branch from 83c94c1 to 42e2788 Compare April 19, 2024 08:55

yajo approved these changes Apr 19, 2024

View reviewed changes

l10n_eu_nace/readme/USAGE.rst Outdated Show resolved Hide resolved

Update l10n_eu_nace/readme/USAGE.rst

471c801

Co-authored-by: Jairo Llopis <[email protected]>

yajo approved these changes Apr 19, 2024

View reviewed changes

rafaelbn approved these changes Apr 21, 2024

View reviewed changes

yajo requested a review from EmilioPascual April 22, 2024 06:29

EmilioPascual approved these changes Apr 22, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 22, 2024

OCA-git-bot added the bot is merging ⏳ label Apr 22, 2024

OCA-git-bot merged commit b961d29 into OCA:16.0 Apr 22, 2024
5 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 22, 2024

yajo deleted the 16.0-mig-l10n_eu_nace branch April 23, 2024 07:44

This was referenced Aug 6, 2024

[16.0][DOCS] update author line in manifest #203

Merged

[17.0][DOCS] update author line in manifest #204

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] l10n_eu_nace new ShowVoc integration #196

[16.0][MIG] l10n_eu_nace new ShowVoc integration #196

edlopen commented Apr 15, 2024 •

edited

Loading

vincent-hatakeyama commented Apr 16, 2024 •

edited

Loading

EmilioPascual left a comment

EmilioPascual Apr 16, 2024

edlopen Apr 19, 2024

EmilioPascual Apr 16, 2024

edlopen Apr 19, 2024

EmilioPascual Apr 16, 2024

edlopen Apr 19, 2024

aronabencherif commented Apr 16, 2024

yajo left a comment

yajo Apr 17, 2024

edlopen Apr 19, 2024

yajo Apr 17, 2024

edlopen Apr 19, 2024

yajo Apr 17, 2024

edlopen Apr 19, 2024

yajo Apr 17, 2024

edlopen Apr 19, 2024

edlopen commented Apr 19, 2024

yajo left a comment

rafaelbn left a comment

OCA-git-bot commented Apr 22, 2024

yajo commented Apr 22, 2024

OCA-git-bot commented Apr 22, 2024

OCA-git-bot commented Apr 22, 2024

edlopen commented Apr 23, 2024

	1. Go to "Contacts" > "Configuration" > "Import NACE Wizard"
	1. Go to "Contacts" > "Configuration" > "Import NACE industries"

	data for each one.
	data for each one. If you activate a new language, remember to run this wizard again.

[16.0][MIG] l10n_eu_nace new ShowVoc integration #196

[16.0][MIG] l10n_eu_nace new ShowVoc integration #196

Conversation

edlopen commented Apr 15, 2024 • edited Loading

vincent-hatakeyama commented Apr 16, 2024 • edited Loading

EmilioPascual left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aronabencherif commented Apr 16, 2024

yajo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

edlopen commented Apr 19, 2024

yajo left a comment

Choose a reason for hiding this comment

rafaelbn left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Apr 22, 2024

yajo commented Apr 22, 2024

OCA-git-bot commented Apr 22, 2024

OCA-git-bot commented Apr 22, 2024

edlopen commented Apr 23, 2024

edlopen commented Apr 15, 2024 •

edited

Loading

vincent-hatakeyama commented Apr 16, 2024 •

edited

Loading