-
-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0] [ADD] product_attribute_variant_rules #1435
[14.0] [ADD] product_attribute_variant_rules #1435
Conversation
product_attribute_variant_rules/views/product_template_views.xml
Outdated
Show resolved
Hide resolved
667ba08
to
ef7040a
Compare
ef7040a
to
c91d340
Compare
product_attribute_variant_rules/models/product_attribute_rule.py
Outdated
Show resolved
Hide resolved
I have rename type into rule_type (I had a issue with product_profile) and type is already a python keyword |
That shouldn't be much of a problem except if you want to use original python |
The issue is related to a bug in product_profile (not so easy to fix). The module was adding a invisible condition in the field "type" (it should not do it). So the quick fix is to rename the field, and as "type" is a python keyword, it make sense to rename it. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (code review + test) used in production
@Kev-Roche can you review ? |
/ocabot merge patch |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 0c1be60. Thanks a lot for contributing to OCA. ❤️ |
This module adds a more powerful way to describe your product attributes combinations than the default exclusions.
It allows to write rules like:
and a short sleeve.
The rules are split between a precondition a type and a postcondition.
Different attributes are ANDed and same attributes are ORed.
For instance the rule::
Will be written as