Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] product_packaging_level: Preserve sequence order #1518

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[16.0][FIX] product_packaging_level: Preserve sequence order
p-tombez committed Feb 14, 2024
commit 5d360e88330c20a0f332167f87cc76ba2323b91d
13 changes: 6 additions & 7 deletions product_packaging_level/models/product_packaging.py
Original file line number Diff line number Diff line change
@@ -8,8 +8,8 @@

class ProductPackaging(models.Model):
_inherit = "product.packaging"
_order = "product_id, level_sequence"

sequence = fields.Integer(compute="_compute_sequence", store=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not related as the prev field?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sequence = fields.Integer(compute="_compute_sequence", store=True)
sequence = fields.Integer(compute="_compute_sequence", store=True, readonly=False)

readonly=False is need otherwise is not possible to edit the field.

packaging_level_id = fields.Many2one(
"product.packaging.level",
required=True,
@@ -19,12 +19,6 @@ class ProductPackaging(models.Model):
barcode_required_for_gtin = fields.Boolean(
readonly=True, compute="_compute_barcode_required_for_gtin"
)
level_sequence = fields.Integer(
string="Level Sequence",
related="packaging_level_id.sequence",
readonly=True,
store=True,
)
qty_per_level = fields.Char(
compute="_compute_qty_per_level", string="Qty per package level"
)
@@ -61,6 +55,11 @@ def _check_one_packaging_level_per_product(self):
).format(product.display_name)
)

@api.depends("packaging_level_id")
def _compute_sequence(self):
for packaging in self:
packaging.sequence = packaging.packaging_level_id.sequence

@api.depends("packaging_level_id", "packaging_level_id.has_gtin", "qty")
def _compute_barcode_required_for_gtin(self):
for packaging in self: