[16.0][FIX] product_packaging_level: Preserve sequence order #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneMangin
approved these changes
Feb 14, 2024
santostelmo
approved these changes
Feb 14, 2024
simahawk
reviewed
Feb 16, 2024
|
|
||
| sequence = fields.Integer(compute="_compute_sequence", store=True) |
There was a problem hiding this comment.
why not related as the prev field?
|
Tests fail unrelated on |
santostelmo
reviewed
Feb 22, 2024
|
|
||
| sequence = fields.Integer(compute="_compute_sequence", store=True) |
There was a problem hiding this comment.
Suggested change
| sequence = fields.Integer(compute="_compute_sequence", store=True) | |
| sequence = fields.Integer(compute="_compute_sequence", store=True, readonly=False) |
readonly=False is need otherwise is not possible to edit the field.
santostelmo
suggested changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore original order to prevent altering behavior when packaging is reordered in the view.
(see explanation here : OCA/sale-workflow#2939 )