Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] product_packaging_level: Preserve sequence order #1525

Conversation

santostelmo
Copy link
Contributor

Restore original order to prevent altering behavior when packaging is reordered in the view.
(see explanation here : OCA/sale-workflow#2939 )

That PR also fixes issue where sequence values could not be edited.
#1518 (review)

@simahawk
Copy link
Contributor

simahawk commented Mar 6, 2024

@santostelmo ping :)
Also: shall we close #1518?

@santostelmo
Copy link
Contributor Author

@santostelmo ping :) Also: shall we close #1518?

IMO we can close 1518.

Tests falling in another module: product_supplierinfo_for_customer

@simahawk
Copy link
Contributor

simahawk commented Mar 6, 2024

Please rebase

@santostelmo santostelmo force-pushed the 16.0-fix-product_packaging_level-packaging-sequence branch from fb61061 to 7e2593e Compare March 6, 2024 13:45
@santostelmo
Copy link
Contributor Author

Rebased

@santostelmo santostelmo force-pushed the 16.0-fix-product_packaging_level-packaging-sequence branch from 7e2593e to eaaff04 Compare March 19, 2024 07:49
@simahawk
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1525-by-simahawk-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cea42a7 into OCA:16.0 Mar 26, 2024
8 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2f66ab1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants