Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] product_packaging_level: Preserve sequence order #1525

Merged
merged 1 commit into from
Mar 26, 2024
+6 −7
Merged

[16.0][FIX] product_packaging_level: Preserve sequence order #1525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions product_packaging_level/models/product_packaging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

class ProductPackaging(models.Model):
_inherit = "product.packaging"
_order = "product_id, level_sequence"

packaging_level_id = fields.Many2one(
"product.packaging.level",
Expand All @@ -19,16 +18,11 @@ class ProductPackaging(models.Model):
barcode_required_for_gtin = fields.Boolean(
readonly=True, compute="_compute_barcode_required_for_gtin"
)
level_sequence = fields.Integer(
string="Level Sequence",
related="packaging_level_id.sequence",
readonly=True,
store=True,
)
qty_per_level = fields.Char(
compute="_compute_qty_per_level", string="Qty per package level"
)
name_policy = fields.Selection(related="packaging_level_id.name_policy")
sequence = fields.Integer(compute="_compute_sequence", store=True, readonly=False)

def default_packaging_level_id(self):
return self.env["product.packaging.level"].search(
Expand Down Expand Up @@ -61,6 +55,11 @@ def _check_one_packaging_level_per_product(self):
).format(product.display_name)
)

@api.depends("packaging_level_id")
def _compute_sequence(self):
for packaging in self:
packaging.sequence = packaging.packaging_level_id.sequence

@api.depends("packaging_level_id", "packaging_level_id.has_gtin", "qty")
def _compute_barcode_required_for_gtin(self):
for packaging in self:
Expand Down
Loading