[17.0][MIG] mail_activity_validation: Migration to 17.0 #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
SilvioC2C
approved these changes
Mar 22, 2024
Comment on lines
+12
to
+21
| group_intersect = False | ||
| if set(self.env.user.groups_id) | set( | ||
| self.activity_type_id.validator_group_ids | ||
| ): | ||
| group_intersect = True | ||
| if ( | ||
| self.activity_type_id.category != "validation" | ||
| or not self.activity_type_id.validator_group_ids | ||
| or group_intersect | ||
| ): |
There was a problem hiding this comment.
Suggested change
| group_intersect = False | |
| if set(self.env.user.groups_id) | set( | |
| self.activity_type_id.validator_group_ids | |
| ): | |
| group_intersect = True | |
| if ( | |
| self.activity_type_id.category != "validation" | |
| or not self.activity_type_id.validator_group_ids | |
| or group_intersect | |
| ): | |
| if ( | |
| self.activity_type_id.category != "validation" | |
| or not self.activity_type_id.validator_group_ids | |
| or self.env.user.groups_id & self.activity_type_id.validator_group_ids | |
| ): |
Comment on lines
+25
to
+31
| _( | ||
| "Only validators in groups {} are " "allowed to validate this activity." | ||
| ).format( | ||
| "\n".join( | ||
| g.display_name for g in self.activity_type_id.validator_group_ids | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Suggested change
| _( | |
| "Only validators in groups {} are " "allowed to validate this activity." | |
| ).format( | |
| "\n".join( | |
| g.display_name for g in self.activity_type_id.validator_group_ids | |
| ) | |
| ) | |
| _( | |
| "Only validators in groups %s are allowed to validate this activity.", | |
| ", ".join(self.activity_type_id.validator_group_ids.mapped("display_name")), | |
| ) |
hbrunn
requested changes
Mar 25, 2024
There was a problem hiding this comment.
I agree with @SilvioC2C's remarks, and no tests at all makes me disinclined to merge this
Camille0907
approved these changes
Mar 25, 2024
rousseldenis
suggested changes
Apr 15, 2024
| class MailActivityType(models.Model): | ||
| _inherit = "mail.activity.type" | ||
|
|
||
| category = fields.Selection(selection_add=[("validation", "Validation")]) |
There was a problem hiding this comment.
Add an ondelete property
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-port of: