Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] mail_activity_validation: Migration to 17.0 #1336

Closed
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add module mail_activity_validation
damdam-s authored and yankinmax committed Mar 21, 2024
commit ec4d688cf88375f36458df8a158ce02733eb44b5
Empty file.
1 change: 1 addition & 0 deletions mail_activity_validation/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from . import models
20 changes: 20 additions & 0 deletions mail_activity_validation/__manifest__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Copyright 2022 Camptocamp SA
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).

{
"name": "Mail Activity Validation",
"version": "12.0.1.0.0",
"category": "Discuss",
"website": "https://github.com/OCA/social",
"author": "Camptocamp SA, Odoo Community Association (OCA)",
"license": "AGPL-3",
"installable": True,
"application": False,
"summary": "Allow to define validation activities",
"depends": [
"mail",
],
"data": [
"views/mail_activity_type.xml",
],
}
3 changes: 3 additions & 0 deletions mail_activity_validation/models/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
from . import mail_activity
from . import mail_activity_mixin
from . import mail_activity_type
33 changes: 33 additions & 0 deletions mail_activity_validation/models/mail_activity.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# Copyright 2022 Camptocamp SA
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)

from odoo import _, models
from odoo.exceptions import AccessError


class MailActivity(models.Model):
_inherit = "mail.activity"

def action_done_schedule_next(self):
group_intersect = False
if set(self.env.user.groups_id) | set(
self.activity_type_id.validator_group_ids
):
group_intersect = True
if (
self.activity_type_id.category != "validation"
or not self.activity_type_id.validator_group_ids
or group_intersect
):
Comment on lines +12 to +21

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
group_intersect = False
if set(self.env.user.groups_id) | set(
self.activity_type_id.validator_group_ids
):
group_intersect = True
if (
self.activity_type_id.category != "validation"
or not self.activity_type_id.validator_group_ids
or group_intersect
):
if (
self.activity_type_id.category != "validation"
or not self.activity_type_id.validator_group_ids
or self.env.user.groups_id & self.activity_type_id.validator_group_ids
):

return super().action_done_schedule_next()

raise AccessError(
_(
"Only validators in groups {} are "
"allowed to validate this activity."
).format(
"\n".join(
g.display_name for g in self.activity_type_id.validator_group_ids
)
)
)
18 changes: 18 additions & 0 deletions mail_activity_validation/models/mail_activity_mixin.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Copyright 2022 Camptocamp SA
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)

from odoo import models


class MailActivityMixin(models.AbstractModel):
_inherit = "mail.activity.mixin"

def check_validation_activities_todo(self):
for rec in self:
remaining_activities = rec.activity_ids.filtered(
lambda a: a.activity_category == "validation"
)

if remaining_activities:
return False
return True
16 changes: 16 additions & 0 deletions mail_activity_validation/models/mail_activity_type.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Copyright 2022 Camptocamp SA
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)

from odoo import fields, models


class MailActivityType(models.Model):
_inherit = "mail.activity.type"

category = fields.Selection(selection_add=[("validation", "Validation")])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an ondelete property

validator_group_ids = fields.Many2many(
"res.groups",
"mail_activity_groups_rel",
"activity_id",
"group_id",
)
1 change: 1 addition & 0 deletions mail_activity_validation/readme/CONTRIBUTORS.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* Damien Crier <damien.crier@camptocamp.com>
3 changes: 3 additions & 0 deletions mail_activity_validation/readme/DESCRIPTION.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
This module allows to define activities as "validation" ones.

This module do nothing if installed as this. You need another module that do something with the "validation" activities.
24 changes: 24 additions & 0 deletions mail_activity_validation/views/mail_activity_type.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<?xml version="1.0" ?>
<!--
Copyright 2022 Camptocamp SA (https://www.camptocamp.com)
License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
-->
<odoo>

<record id="mail_activity_type_view_form" model="ir.ui.view">
<field name="model">mail.activity.type</field>
<field name="inherit_id" ref="mail.mail_activity_type_view_form" />
<field name="arch" type="xml">
<xpath expr="//sheet" position="inside">
<div
name="activities_validators"
attrs="{'invisible': [('category', '!=', 'validation')]}"
>
<label for="validator_group_ids" />
<field name="validator_group_ids" nolabel="1" />
</div>
</xpath>
</field>
</record>

</odoo>
6 changes: 6 additions & 0 deletions setup/mail_activity_validation/setup.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import setuptools

setuptools.setup(
setup_requires=['setuptools-odoo'],
odoo_addon=True,
)