Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] stock_dangerous_goods: Migration to 18.0 #1786

Merged
merged 7 commits into from
Feb 4, 2025

Conversation

xaviedoanhduy
Copy link

@xaviedoanhduy xaviedoanhduy mentioned this pull request Dec 10, 2024
40 tasks
@jbaudoux
Copy link
Contributor

/ocabot migration stock_dangerous_goods

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Dec 31, 2024
Copy link
Contributor

@bizzappdev bizzappdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and Functionality both LGTM

@bizzappdev
Copy link
Contributor

Added the Test cases in the PR: https://github.com/xaviedoanhduy/stock-logistics-workflow/pull/2/files

@simahawk
Copy link
Contributor

simahawk commented Feb 3, 2025

@xaviedoanhduy can you pls rewrite the last commit msg by removing the odoo version and shortening the msg?

[add] stock_dangerous_goods: add tests is more than enough 😉

@xaviedoanhduy xaviedoanhduy force-pushed the 18.0-mig-stock_dangerous_goods branch 2 times, most recently from 6ca16c3 to 437e909 Compare February 4, 2025 07:48
@xaviedoanhduy
Copy link
Author

hi @simahawk, I have changed the message of the last commit

@simahawk
Copy link
Contributor

simahawk commented Feb 4, 2025

@xaviedoanhduy cool, the only thing remaing: drop the test dep 😉

@xaviedoanhduy xaviedoanhduy force-pushed the 18.0-mig-stock_dangerous_goods branch from 437e909 to 8f4d295 Compare February 4, 2025 07:59
@simahawk
Copy link
Contributor

simahawk commented Feb 4, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-1786-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit aa75d39 into OCA:18.0 Feb 4, 2025
2 of 5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e62c69b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants