-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] stock_dangerous_goods: Migration to 18.0 #1786
[18.0][MIG] stock_dangerous_goods: Migration to 18.0 #1786
Conversation
/ocabot migration stock_dangerous_goods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and Functionality both LGTM
Added the Test cases in the PR: https://github.com/xaviedoanhduy/stock-logistics-workflow/pull/2/files |
@xaviedoanhduy can you pls rewrite the last commit msg by removing the odoo version and shortening the msg?
|
6ca16c3
to
437e909
Compare
hi @simahawk, I have changed the message of the last commit |
@xaviedoanhduy cool, the only thing remaing: drop the test dep 😉 |
437e909
to
8f4d295
Compare
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at e62c69b. Thanks a lot for contributing to OCA. ❤️ |
depend on: OCA/community-data-files#211