-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds persistence and reloading of datatable pagination params #2112
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavgra just testing this out and it seems like what you've built here works well for the data table component itself. That said, it looks like perhaps the other parts of the application need to be more aware of the state of the data table. Take for example the following workflow:
- Navigate to the cohort definition list via the left-hand menu
- Filter the list using the search which results in a URL like:
http://localhost:81/atlas/#/cohortdefinitions?dtSearch_-1258431457=ehden&dtPage_-1258431457=0
- Open a cohort definition from that list
- Close the cohort definition
I'd expect that closing the cohort definition would preserve the query string parameters required to filter the data table contents but that seems to get lost in the process. Could you take a look or let me know if you need any further details? Thanks!
@anthonysena , I do not think that this case can be implemented in a straightforward and clean way:
|
I'd like to confirm with @gklebanov around the functional requirements for #760 before we merge this into master. |
fixes #760