Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dbfetch #35

Merged
merged 8 commits into from
Nov 28, 2023
Merged

Dbfetch #35

merged 8 commits into from
Nov 28, 2023

Conversation

jreps
Copy link
Collaborator

@jreps jreps commented Nov 28, 2023

  • optimized aggregate features
  • optimized database extraction

jreps and others added 8 commits November 10, 2023 11:51
@jreps
Update Database.R
f5c2028 
- adding code to export in batches
Using dbFetch to export to CSV in batches. Deprecating targetDialect …
4e64c9a 
…argument.
Fix typo in DESCRIPTION
543f77e
Handling case when table in SQLite is empty
44c727c
Fix error in dechallenge_rechallenge minCellCount
fb4c408
Adding minMeanCovariateValue argument to exportDatabaseToCsv
e1addc2
@jreps
optimizing aggregate features
570bf4f 
- removing T and not Os from aggregate since these can be calculated from T and T with Os
- updating tests after removing T and not Os
- updating function to export to csv in batches when a table is empty
Merge branch 'exporting_batches' into dbfetch
a1e756d 
# Conflicts:
#	R/Database.R
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (739a772) 86.55% compared to head (a1e756d) 86.62%.
Report is 8 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop      #35      +/-   ##
===========================================
+ Coverage    86.55%   86.62%   +0.07%     
===========================================
  Files            8        8              
  Lines         1324     1331       +7     
===========================================
+ Hits          1146     1153       +7     
  Misses         178      178

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jreps jreps merged commit 5bb9990 into develop Nov 28, 2023
12 checks passed
@jreps jreps deleted the dbfetch branch November 28, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jreps