fixing issue 415

bug fix in ohdsi shiny modules version check
OHDSI · Oct 11, 2023 · e6a6c93 · e6a6c93
1 parent 559c7ef
commit e6a6c93
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -2,8 +2,8 @@ Package: PatientLevelPrediction
 Type: Package
 Title: Developing patient level prediction using data in the OMOP Common Data
     Model
-Version: 6.3.5.9000
-Date: 2023-08-15
+Version: 6.3.6
+Date: 2023-10-09
 Authors@R: c(
     person("Jenna", "Reps", email = "[email protected]", role = c("aut", "cre")),
     person("Martijn", "Schuemie", role = c("aut")),

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+PatientLevelPrediction 6.3.6
+======================
+- fix bug with ohdsi shiny modules version check (issue 415)
+
 PatientLevelPrediction 6.3.5
 ======================
 - Fix sklearnToJson to be compatible with scikit-learn>=1.3

diff --git a/R/ViewShinyPlp.R b/R/ViewShinyPlp.R
@@ -154,7 +154,7 @@ viewPlps <- function(databaseSettings){
     )
   } else{
     ohdsiModulesVersion <- strsplit(x = as.character(utils::packageVersion('OhdsiShinyModules')), split = '\\.')[[1]]
-    if(ohdsiModulesVersion[1]>=1 & ohdsiModulesVersion[2]>= 2){
+    if(paste0(ohdsiModulesVersion[1], ".", ohdsiModulesVersion[2])>= 1.2){
       config <- ParallelLogger::loadSettingsFromJson(
         fileName = system.file(
           'shinyConfigUpdate.json',