Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

413 python fix #414

Merged
merged 2 commits into from
Oct 11, 2023
Merged

413 python fix #414

merged 2 commits into from
Oct 11, 2023

Conversation

egillax
Copy link
Collaborator

@egillax egillax commented Oct 10, 2023

Hi @jreps ,

This is a fix for a python issue which was causing tests to fail. After this fix tests on windows and ubuntu should pass, while tests on macOS are still failing because of the vroom issue that's affecting many.

I've now set as a default python version 3.11 when creating a new conda environment using the configurePython function.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (820e05e) 89.40% compared to head (1338f34) 89.38%.
Report is 2 commits behind head on develop.

❗ Current head 1338f34 differs from pull request most recent head 6ab80dd. Consider uploading reports for the commit 6ab80dd to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #414      +/-   ##
===========================================
- Coverage    89.40%   89.38%   -0.03%     
===========================================
  Files           49       49              
  Lines         9826     9826              
===========================================
- Hits          8785     8783       -2     
- Misses        1041     1043       +2     
Files Coverage Δ
R/HelperFunctions.R 62.65% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jreps jreps merged commit 0fe1b78 into develop Oct 11, 2023
6 of 8 checks passed
@egillax egillax deleted the 413-python_fix branch November 30, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants