Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding renv.lock helper functions #116

Merged
merged 8 commits into from
Jan 26, 2024
Merged

Conversation

anthonysena
Copy link
Collaborator

Adds additional functions to aid in module development and validation per #69.

Additional changes in this PR:

  • Fixed targets script for results upload that was still calling out to Strategus vs using the injected method.
  • Updated the UnitTestModule embedded in this package to use the approach described in Using renv project profiles for modules #94 for project profiles.
  • Update the test analysisSpeficiation.json to use the latest release of the HADES modules and updated the internal modules.csv reference accordingly.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (13d020e) 69.19% compared to head (a5cdae3) 71.72%.
Report is 1 commits behind head on develop.

Files Patch % Lines
R/RenvHelpers.R 95.00% 5 Missing ⚠️
R/ResultsUpload.R 0.00% 1 Missing ⚠️
R/RunModule.R 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #116      +/-   ##
===========================================
+ Coverage    69.19%   71.72%   +2.52%     
===========================================
  Files            8        9       +1     
  Lines          922     1022     +100     
===========================================
+ Hits           638      733      +95     
- Misses         284      289       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anthonysena anthonysena merged commit cc40531 into develop Jan 26, 2024
12 checks passed
@anthonysena anthonysena deleted the renv_lock_validation branch April 23, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant