Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enip/detect: remove double registration of enip_command keyword #11981

Closed
wants to merge 1 commit into from

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/3958 follow up

Describe changes:

  • enip/detect: remove double registration of enip_command keyword

credits to @regit for finding it

(must have come from some git rebase)

As found with
./src/suricata --list-keywords | sort | uniq -c | awk '$1 > 1'
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.72%. Comparing base (37fa2a6) to head (a0201f6).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11981      +/-   ##
==========================================
- Coverage   82.77%   82.72%   -0.06%     
==========================================
  Files         910      910              
  Lines      249016   249000      -16     
==========================================
- Hits       206134   205983     -151     
- Misses      42882    43017     +135     
Flag Coverage Δ
fuzzcorpus 60.80% <ø> (+0.03%) ⬆️
livemode 18.70% <ø> (-0.01%) ⬇️
pcap 44.06% <ø> (-0.03%) ⬇️
suricata-verify 62.23% <ø> (+0.04%) ⬆️
unittests 59.01% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23124

@victorjulien victorjulien added this to the 8.0 milestone Oct 18, 2024
@victorjulien
Copy link
Member

Merged in #12004, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants