next/607/20241021/v1 #12004
Merged
next/607/20241021/v1 #12004
+126
−189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As found with ./src/suricata --list-keywords | sort | uniq -c | awk '$1 > 1'
The profiling arrays are incorrectly sized by the number of thread modules. Since they contain app-layer protocol data, they should be sized by ALPROTO_MAX.
Adds custom fields "client_alpns" and "server_alpns". Ticket: OISF#7333
During EVE TLS setup, a broken check for Ja3 being enabled led to Ja3 being disabled, but only in custom mode. This check is not needed, if Ja3 is disabled, it won't be available, and won't be logged. This is required to implement "extended" in terms of "custom" fields.
Will prevent custom logging options getting out of sync with whats available in extended. Ticket: OISF#7333
Also update the suricata.yaml in the userguide.
Minor cleanup.
victorjulien
requested review from
jasonish,
jufajardini and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12004 +/- ##
==========================================
+ Coverage 82.75% 83.22% +0.47%
==========================================
Files 910 910
Lines 249016 258136 +9120
==========================================
+ Hits 206069 214831 +8762
- Misses 42947 43305 +358
Flags with carried forward coverage won't be shown. Click here to find out more. |
jasonish
approved these changes
Oct 21, 2024
|
Information: QA ran without warnings. Pipeline 23145 |
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging: