Remove duplicate function declarations - v2 #11990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket:7297
5 tasks
|
NOTE: This PR may contain new authors. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11990 +/- ##
==========================================
+ Coverage 82.75% 83.08% +0.33%
==========================================
Files 910 910
Lines 249016 258182 +9166
==========================================
+ Hits 206069 214522 +8453
- Misses 42947 43660 +713
Flags with carried forward coverage won't be shown. Click here to find out more. |
jufajardini
changed the title
jufajardini
requested changes
Oct 19, 2024
There was a problem hiding this comment.
Thanks for this work, a few comments:
- could you reword the commit message to follow our guidelines? Since you're working on assorted files, you can use a style like c9e4524b3c71d0177
- a more nit one, but it's also important to pay attention to details: can you add a whitespace in the commit body message? it's currently
Task:7297 - you could also add to the commit body the command that was used to find these, for completion ;)
More generic ones:
- please don't forget to add the ticket link to your PR, as it helps us in case we want to check the ticket
- the PR checks that read (if applicable), you can remove if none will be checked, for a cleaner PR description :)
Comment on lines
-31
to
-32
| void AlertQueueInit(DetectEngineThreadCtx *det_ctx); | ||
| void AlertQueueFree(DetectEngineThreadCtx *det_ctx); |
There was a problem hiding this comment.
Since these are defined in src/detect-engine-alert.c, I think it's better to keep these declarations, remove the duplicate ones in the other file, and then add this hear as an include.
2 tasks
|
work continued on #11993 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:7297
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Describe changes:
-Remove duplicate function declarations in header files
-previous pr #11988
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=