Remove duplicate function declarations-v3 #11993
Conversation
There was a problem hiding this comment.
@Nancyenos Nice work! Looking good from the first look. :)
Minor change requested inline.
Also, I think Juliana's first point in this comment on your last PR still needs attention: #11990 (review)
| @@ -1594,8 +1594,6 @@ void *DetectGetInnerTx(void *tx_ptr, AppProto alproto, AppProto engine_alproto, | |||
| void RuleMatchCandidateTxArrayInit(DetectEngineThreadCtx *det_ctx, uint32_t size); | |||
| void RuleMatchCandidateTxArrayFree(DetectEngineThreadCtx *det_ctx); | |||
|
|
|||
| void AlertQueueInit(DetectEngineThreadCtx *det_ctx); | |||
| void AlertQueueFree(DetectEngineThreadCtx *det_ctx); | |||
| void AlertQueueAppend(DetectEngineThreadCtx *det_ctx, const Signature *s, Packet *p, uint64_t tx_id, | |||
There was a problem hiding this comment.
I think this fn is also duplicated.
|
Hey @inashivb , please can you kindly explain what am doing wrong with the commit? |
Just add a prefix |
ooh. Thank you/Totally missed it 😃 |
|
work continued in #11998 |
Ticket: #7297
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7297
Describe changes:
-Remove duplicate function declarations fro header files
-I used this to find the duplicates:
Previous pr #11990