Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

t.unregister: add support to unregister maps from other mapsets #2447

Merged
merged 2 commits into from
Jun 17, 2022
Merged

t.unregister: add support to unregister maps from other mapsets #2447

merged 2 commits into from
Jun 17, 2022

Conversation

anikaweinmann
Copy link
Contributor

By the try to unregister raster maps from a STRDS an error accured:

t.unregister input=test_strds@test_mapest maps=elevation@PERMANENT
Unregister maps
ERROR: Unable to execute sql statement. You have no permission to access
mapset <PERMANENT>, or mapset <PERMANENT> has no temporal database.
Accessible mapsets are: <test_mapset>

This changes fixes this bug and you can unregister raster maps from other mapset in the STRDS.

@anikaweinmann anikaweinmann mentioned this pull request Jun 17, 2022
Open
@metzm metzm self-requested a review June 17, 2022 13:39
@metzm metzm added bug Something isn't working backport_needed temporal Related to temporal data processing Python Related code is in Python labels Jun 17, 2022
@metzm metzm added this to the 8.2.1 milestone Jun 17, 2022
@metzm
Copy link
Contributor

metzm commented Jun 17, 2022

Just for clarification: this PR makes sure that t.unregister only modifies the TGIS db and thus a STDS in the current mapset. Actual maps to be unregistered can be located in different mapsets. The same has already been implemented for t.register.

metzm
metzm approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@metzm metzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@neteler neteler changed the title t.unregister: add support to unregister maps form other mapsets t.unregister: add support to unregister maps from other mapsets Jun 17, 2022
@wenzeslaus
Copy link
Member

Thanks for the clarification @metzm!

@metzm metzm merged commit 1957229 into OSGeo:main Jun 17, 2022
metzm added a commit that referenced this pull request Jun 17, 2022
@anikaweinmann @metzm
t.unregister: add support to unregister maps from other mapsets (#2447)
bfbe003 
* add support to unregister maps from other mapsets in the TGIS db of the current mapset

Co-authored-by: Markus Metz <[email protected]>

Co-authored-by: anikaweinmann <[email protected]>
Co-authored-by: Markus Metz <[email protected]>
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@anikaweinmann @metzm @ninsbl
t.unregister: add support to unregister maps from other mapsets (OSGe…
6531fb8 
…o#2447)

* add support to unregister maps from other mapsets in the TGIS db of the current mapset

Co-authored-by: Markus Metz <[email protected]>

Co-authored-by: anikaweinmann <[email protected]>
Co-authored-by: Markus Metz <[email protected]>
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@anikaweinmann @metzm @ninsbl
t.unregister: add support to unregister maps from other mapsets (OSGe…
f342256 
…o#2447)

* add support to unregister maps from other mapsets in the TGIS db of the current mapset

Co-authored-by: Markus Metz <[email protected]>

Co-authored-by: anikaweinmann <[email protected]>
Co-authored-by: Markus Metz <[email protected]>
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@anikaweinmann @metzm @neteler
t.unregister: add support to unregister maps from other mapsets (OSGe…
e0d13ca 
…o#2447)

* add support to unregister maps from other mapsets in the TGIS db of the current mapset

Co-authored-by: Markus Metz <[email protected]>

Co-authored-by: anikaweinmann <[email protected]>
Co-authored-by: Markus Metz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metzm metzm metzm approved these changes

@wenzeslaus wenzeslaus wenzeslaus left review comments

Assignees
No one assigned
Labels
bug Something isn't working Python Related code is in Python temporal Related to temporal data processing
Projects
None yet
Milestone
8.2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@anikaweinmann @metzm @wenzeslaus @neteler