fix: Publish artifacts with semantic-release releases #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aashish24 If you look at the release page, there is currently a v1.0.3-beta.1 release. You can see that it has 6 build artifacts: With semantic-release it is easy to control the names that appear. Maybe it would be better to have something like: Thoughts? |
It looks like this will maintain our manual changes, too.
|
Closes #1095. |
|
I think Full JS Distribution (geo.js) will appeal better |
|
I agree. I made that change in the second commit on this branch. I think it will also now update the CHANGELOG correctly, too (but I'm not sure how test it other than by merging). |
aashish24
approved these changes
Jun 15, 2021
|
🎉 This PR is included in version 1.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With semantic release, there is a different technique to publish the build artifacts to the github releases. This switches to it.