Char Move Slot and Rename #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll rebase this |
cydh
force-pushed
the
feature/char_move_and_rename
branch
from
a278e3c
to
4f8f089
Compare
|
@cydh we have a few more conflicts to solve here :( |
sctnightcore
approved these changes
Sep 30, 2017
* Move Character Slot
* Move slot option now will be shown on chracter select (+2 after char slot, after create new char option)
* Known used packet:
* char_move_slot (08D4): To send char move request.
* char_move_slot_reply (08D5): Reply for char move.
* Rename Character
* Rename slot option now will be shown on chracter select (+3 after char slot, after move char slot option)
* Known used packet:
* char_rename (08FC): To send rename request.
* char_renamed (08E3): Received a single charinfo for renamed char, only be sent by server if renaming is success.
* char_rename_result (08FD): Reply of rename request.
* Misc Edits
* Delete option will be shown as +3 after char slot
* Edited `received_characters_unpackString` unpack string notation to support 'Move Character Slot' and 'Rename Character' feature.
* Added function 'sub received_characters_unpackString_Min' to unpack 'CharInfo' packet for renamed char.
* PS: Only tested for idRO server, TODO maybe I'll do some tests for @rathena
Signed-off-by: Cydh Ramdh <[email protected]>
Signed-off-by: Cydh Ramdh <[email protected]>
cydh
force-pushed
the
feature/char_move_and_rename
branch
from
4f8f089
to
c9301db
Compare
|
rebased and |
|
Is this pull request still good?? i don't know anything about this |
# Conflicts: # src/Network/Receive.pm # src/Network/Receive/ServerType0.pm # src/Network/Send.pm # src/Network/Send/ServerType0.pm # tables/packetdescriptions.txt
* Correction * Tested in idRO (~8x times LOL)
* removed lefctover * Fixed and tested with idRO Renewal
alisonrag
approved these changes
Jan 3, 2019
|
@cydh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
received_characters_unpackStringunpack string notation to support 'Move Character Slot' and 'Rename Character' feature.Signed-off-by: Cydh Ramdh [email protected]