-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Char Move Slot and Rename #101
Open
cydh
wants to merge
7
commits into
OpenKore:master
Choose a base branch
from
cydh:feature/char_move_and_rename
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+270
−2
Commits on Oct 10, 2017
-
* Move Character Slot * Move slot option now will be shown on chracter select (+2 after char slot, after create new char option) * Known used packet: * char_move_slot (08D4): To send char move request. * char_move_slot_reply (08D5): Reply for char move. * Rename Character * Rename slot option now will be shown on chracter select (+3 after char slot, after move char slot option) * Known used packet: * char_rename (08FC): To send rename request. * char_renamed (08E3): Received a single charinfo for renamed char, only be sent by server if renaming is success. * char_rename_result (08FD): Reply of rename request. * Misc Edits * Delete option will be shown as +3 after char slot * Edited `received_characters_unpackString` unpack string notation to support 'Move Character Slot' and 'Rename Character' feature. * Added function 'sub received_characters_unpackString_Min' to unpack 'CharInfo' packet for renamed char. * PS: Only tested for idRO server, TODO maybe I'll do some tests for @rathena Signed-off-by: Cydh Ramdh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 04a428d - Browse repository at this point
Copy the full SHA 04a428dView commit details -
Updated tables/packetdescriptions.txt
Signed-off-by: Cydh Ramdh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c9301db - Browse repository at this point
Copy the full SHA c9301dbView commit details
Commits on Dec 19, 2018
-
Merge branch 'master' into feature/char_move_and_rename
# Conflicts: # src/Network/Receive.pm # src/Network/Receive/ServerType0.pm # src/Network/Send.pm # src/Network/Send/ServerType0.pm # tables/packetdescriptions.txt
Configuration menu - View commit details
-
Copy full SHA for 5ce948a - Browse repository at this point
Copy the full SHA 5ce948aView commit details -
Configuration menu - View commit details
-
Copy full SHA for dae2e74 - Browse repository at this point
Copy the full SHA dae2e74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 704e8dc - Browse repository at this point
Copy the full SHA 704e8dcView commit details -
* removed lefctover * Fixed and tested with idRO Renewal
Configuration menu - View commit details
-
Copy full SHA for 5561b87 - Browse repository at this point
Copy the full SHA 5561b87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07e374e - Browse repository at this point
Copy the full SHA 07e374eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.