Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guides: deployment #152

Merged
merged 1 commit into from
Dec 7, 2023
Merged

guides: deployment #152

merged 1 commit into from
Dec 7, 2023

Conversation

ElysaSrc
Copy link
Member

@ElysaSrc ElysaSrc commented Nov 24, 2023 •
edited
Loading

This modification add guides that cover deployments

  • Describe container architecture
    • English
    • French
  • Helm depoloyments
    • English
    • French
  • Docker compose deployments
    • English
    • French

@ElysaSrc ElysaSrc marked this pull request as draft November 24, 2023 09:05
@ElysaSrc ElysaSrc mentioned this pull request Nov 24, 2023
Closed
2 tasks
@ElysaSrc ElysaSrc force-pushed the ev/deploy-doc branch 2 times, most recently from e65601e to 523e535 Compare November 24, 2023 09:50
multun
multun suggested changes Dec 4, 2023
View reviewed changes
content/docs/guides/deploy/kubernetes/_index.en.md Outdated Show resolved Hide resolved
content/docs/guides/deploy/kubernetes/_index.en.md Outdated Show resolved Hide resolved
content/docs/guides/deploy/kubernetes/_index.fr.md Outdated Show resolved Hide resolved
content/docs/guides/deploy/kubernetes/_index.fr.md Outdated Show resolved Hide resolved
@ElysaSrc ElysaSrc marked this pull request as ready for review December 4, 2023 14:44
@ElysaSrc ElysaSrc requested a review from multun December 4, 2023 14:45
celine-sncf
celine-sncf requested changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@celine-sncf celine-sncf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected a few typos

content/docs/explanation/containers-architecture/_index.en.md Outdated Show resolved Hide resolved
content/docs/explanation/containers-architecture/_index.en.md Outdated Show resolved Hide resolved
content/docs/explanation/containers-architecture/_index.en.md Outdated Show resolved Hide resolved
content/docs/explanation/containers-architecture/_index.fr.md Outdated Show resolved Hide resolved
content/docs/explanation/containers-architecture/_index.fr.md Outdated Show resolved Hide resolved
content/docs/guides/deploy/kubernetes/_index.fr.md Outdated Show resolved Hide resolved
content/docs/guides/deploy/kubernetes/_index.fr.md Outdated Show resolved Hide resolved
content/docs/guides/deploy/kubernetes/_index.fr.md Outdated Show resolved Hide resolved
content/docs/guides/deploy/kubernetes/_index.fr.md Outdated Show resolved Hide resolved
content/docs/guides/deploy/kubernetes/_index.fr.md Show resolved Hide resolved
celine-sncf
celine-sncf approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@celine-sncf celine-sncf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the corrections :)

@multun multun merged commit 5753bf3 into master Dec 7, 2023
1 check passed
@multun multun deleted the ev/deploy-doc branch December 7, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@multun multun multun approved these changes

@celine-sncf celine-sncf celine-sncf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElysaSrc @multun @celine-sncf