Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft for discussion: Feature/add elements to detection classification #657

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

FlorianMueller87
Copy link
Contributor

@FlorianMueller87 FlorianMueller87 commented Aug 5, 2022

Reference to a related issue in the repository

#643

Add a description

ASAM OSI and ISO 23150 or AUTOSAR ADI have a common history. Unfortunately, the inner structure, the naming and the definitions of the standards are differentiated from each other. This makes the work of developers unnecessary complicated for mostly no technical reasons. All sides should strive to reduce inequality.

ASAM OSI need the entries for osi_featuredata – DetectionClassification to be compatible with AUTOSAR ADI DetectionClassificationType.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • My suggestion follows the style and contributors guidelines.
  • I have taken care about the documentation.
  • I have done the DCO signoff.
  • My changes generate no errors when passing CI tests.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

Describe alternatives you have considered

No alternative was considered.

Describe the backwards compatibility

The adding of the elements will not lead to backward compatibility issues.
Additional context

ISO23150:2021 A.4.14 Detection classification type

@ThomasNaderBMW @jdsika @schmidtlorenz

@FlorianMueller87 FlorianMueller87 force-pushed the feature/add_elements_to_DetectionClassification branch from aadcd6d to 27376ac Compare August 9, 2022 09:05
@FlorianMueller87 FlorianMueller87 changed the title Feature/add elements to detection classification Draft for discussion: Feature/add elements to detection classification Aug 9, 2022
@FlorianMueller87 FlorianMueller87 force-pushed the feature/add_elements_to_DetectionClassification branch from 27376ac to 15dfb4b Compare August 12, 2022 07:24
@jdsika jdsika added the Harmonisation The Group in the ASAM development project working on harmonisation with other standards. label Oct 17, 2022
@jdsika
Copy link
Contributor

jdsika commented Oct 17, 2022

NEAREST and STRONGEST seem to be parameters for the search of objekts. It is completely different to define something as UNDERDRIVABLE or as NEAREST. Something can be CLUTTER and at the same time be the NEAREST. Please clarify why the ISO did define it like this @carsten-kuebler ?

@jdsika jdsika linked an issue Oct 17, 2022 that may be closed by this pull request
@ClemensLinnhoff ClemensLinnhoff added the AUTOSAR ADI Topics connected to AUTOSAR ADI definition. label Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AUTOSAR ADI Topics connected to AUTOSAR ADI definition. Harmonisation The Group in the ASAM development project working on harmonisation with other standards.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISO23150 compliance: Adding new states to [DetectionClassification]
3 participants