Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
The speed setted by a mission was never used.
Moreover after the previous refactoring the distance between the rover and waypoints was not updated correctly.
Thus making the desired speed locked at corner speed and breaking the delay command detection.
Solution
Mission speed usage :
Distance update :
Test coverage
Context
Before :
![old](https://private-user-images.githubusercontent.com/145494402/359173806-ef686f34-9169-488c-ab42-7a8c3f43cc16.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1Mjk3NzMsIm5iZiI6MTczOTUyOTQ3MywicGF0aCI6Ii8xNDU0OTQ0MDIvMzU5MTczODA2LWVmNjg2ZjM0LTkxNjktNDg4Yy1hYjQyLTdhOGMzZjQzY2MxNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQxMDM3NTNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05Y2VjMTEzOGU5OWRiMDUwMjQ4ZmIyNjNmMmI0Mjg2NTMyNTJlMzJhODU4NjM2NDA3NzMxMTllMzQyYjg4OTFmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.fsY1iiGiYtFHzz-okG0wz-D-ovdSk1yJF1u-ZCO9bUM)
![old with explanation](https://private-user-images.githubusercontent.com/145494402/359173817-e1f979fa-0dfe-4889-b686-f04a76a0b1e3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1Mjk3NzMsIm5iZiI6MTczOTUyOTQ3MywicGF0aCI6Ii8xNDU0OTQ0MDIvMzU5MTczODE3LWUxZjk3OWZhLTBkZmUtNDg4OS1iNjg2LWYwNGE3NmEwYjFlMy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQxMDM3NTNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05NWE4OThlZjcwNzI4ZWNlNTI2ZWVmMTMzYWVjNTRiYjZlMTE0MmI0Y2Q5OGFkMjg4M2NiODA4Yzk5ODlhMzk2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9._W9TBN2_CRq7ZLCTWRTPx_a3dhDggRdYO1ISR_KlkEg)
https://logs.px4.io/plot_app?log=ae0bb8f4-33a1-475c-8775-2324e9f51efe
After :
![new](https://private-user-images.githubusercontent.com/145494402/359173853-d2ac3e98-af77-4690-b08e-2a9cea60b6e9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1Mjk3NzMsIm5iZiI6MTczOTUyOTQ3MywicGF0aCI6Ii8xNDU0OTQ0MDIvMzU5MTczODUzLWQyYWMzZTk4LWFmNzctNDY5MC1iMDhlLTJhOWNlYTYwYjZlOS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQxMDM3NTNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02YzMzNDlhNmUxOTkyNTI3YjcyMTg2OWYzZDk1N2E5MWQyYWNiN2E4MmIzOWU5MjQ4OTc5MjBiNzBlZGEyYmY3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.OvP9OvsN9EJIiXUuZg5TX1mXY02YvcCQzcpurZzxBrI)
![new with explanation](https://private-user-images.githubusercontent.com/145494402/359173858-09901c56-c19a-4482-8a37-4c6d1066a09f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1Mjk3NzMsIm5iZiI6MTczOTUyOTQ3MywicGF0aCI6Ii8xNDU0OTQ0MDIvMzU5MTczODU4LTA5OTAxYzU2LWMxOWEtNDQ4Mi04YTM3LTRjNmQxMDY2YTA5Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQxMDM3NTNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jMTJmMTIyMDA0YTNhZmM5OTY0Zjk3NmVkMThkMTIyZDcwNDIxZmRmYzJiMWI3NjNlMmQxMTI1MTRmZGVhZGY3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.sqWqXqFWjs55AlM3DJ_X-Q1Fi1LT2vtwEG6AoKJ-jdc)
https://logs.px4.io/plot_app?log=0f6779c8-02d4-4029-9802-7004f81d3e9e