Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ackermann speed from mission #23572

Merged
merged 8 commits into from
Aug 27, 2024

Conversation

sbtjagu
Copy link
Contributor

@sbtjagu sbtjagu commented Aug 19, 2024

Solved Problem

The speed setted by a mission was never used.
Moreover after the previous refactoring the distance between the rover and waypoints was not updated correctly.
Thus making the desired speed locked at corner speed and breaking the delay command detection.

Solution

Mission speed usage :

  • When updating waypoints from position_setpoint_triplet we get the desired speed if it is lower than _param_ra_miss_vel_def in airframe, and use it instead.

Distance update :

  • Moving distance update from updateWaypointsAndAcceptanceRadius to computeGuidance

Test coverage

  • SITL testing

Context

Before :
old
old with explanation

https://logs.px4.io/plot_app?log=ae0bb8f4-33a1-475c-8775-2324e9f51efe

After :
new
new with explanation

https://logs.px4.io/plot_app?log=0f6779c8-02d4-4029-9802-7004f81d3e9e

@chfriedrich98 chfriedrich98 self-requested a review August 26, 2024 07:25
@chfriedrich98 chfriedrich98 added the Rover 🚙 Rovers and other UGV label Aug 26, 2024
Copy link
Contributor

@chfriedrich98 chfriedrich98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, thanks for the implementation!
I just have one small change to adress.

@chfriedrich98 chfriedrich98 self-assigned this Aug 26, 2024
@chfriedrich98 chfriedrich98 self-requested a review August 27, 2024 11:33
@chfriedrich98 chfriedrich98 merged commit be4d0d3 into PX4:main Aug 27, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rover 🚙 Rovers and other UGV
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants