Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gazebo Harmonic replaces Garden #3367

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Gazebo Harmonic replaces Garden #3367

merged 2 commits into from
Sep 5, 2024

Conversation

hamishwillee
Copy link
Collaborator

Replaces #3366

This updates documents in line with PX4/PX4-Autopilot#23603

Note that there are questions in PX4/PX4-Autopilot#23603 (comment)

  • Foxy can't be used with Harmonic - do we drop Foxy, keep Garden, or do something else?
  • What about macOS? Dev instructions don't cover version, so there is no docs change, but we should make sure that it is up to date.
  • Do we backport this info.

@@ -50,6 +50,10 @@ Please continue reading for [upgrade instructions](#upgrade-guide).
- [SIH]: The SIH on SITL [custom takeoff location](../sim_sih/index.md#set-custom-takeoff-location) in now set using the normal unscaled GPS position values, where previously the value needed to be multiplied by 1E7.
([PX4-Autopilot#23363](https://github.com/PX4/PX4-Autopilot/pull/23363)).
- [Gazebo]:
- Gazebo Harmonic LTS release replaces Gazebo Garden as the version supported by PX4.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Gazebo Harmonic LTS release replaces Gazebo Garden as the version supported by PX4.
- Gazebo Harmonic LTS release replaces Gazebo Garden as the version supported by PX4 on Ubuntu 22.04 onward.

@hamishwillee is it worth mentioning this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but perhaps not here. I will look at this next week :-)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided not to mention. Why? Because I'm pushing Harmonic/Ubuntu 22.04 as the supported version. Yes, we allow 20.04, but we can't say we support it because there is no ROS 2 version on Ubuntu 22.04 that hasn't reached EOL.

en/sim_gazebo_classic/index.md Show resolved Hide resolved
en/ros2/user_guide.md Show resolved Hide resolved
Copy link

github-actions bot commented Sep 5, 2024

No flaws found

@hamishwillee
Copy link
Collaborator Author

Thanks @Kametor @beniaminopozzan .

The "story" now is that Harmonic/Ubuntu 22.04 as the supported ROS 2 development environment. That is objectively true in 2 months: Foxy is EOL now, Garden will be in November, and there are no other ROS 2 variants that run on Ubuntu 22.04.

However I haven't removed the Foxy instructions. Just noted that they still work but you really should upgrade.

@hamishwillee hamishwillee merged commit 28b55bd into main Sep 5, 2024
1 of 3 checks passed
@hamishwillee hamishwillee deleted the garden_to_harmonic branch September 5, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants