Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gz version to harmonic #23603

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Update gz version to harmonic #23603

merged 1 commit into from
Aug 23, 2024

Conversation

Jaeyoung-Lim
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim commented Aug 22, 2024

Solved Problem

The EOL is approaching for gz garden (Nov 2024)

https://gazebosim.org/docs/latest/releases/

Solution

Update release to a LTS release of Gz (harmonic)

Changelog Entry

For release notes:

Feature/Bugfix Bump default version of gz to harmonic
Documentation: Need to update the documentation to use gz harmonic

Alternatives

No alternatives

Test coverage

  • Tested with gz
make px4_sitl gz_x500

Context

  • This might fix the airspeed sensor issue go away

@Jaeyoung-Lim Jaeyoung-Lim requested a review from dagar August 22, 2024 20:57
@Jaeyoung-Lim Jaeyoung-Lim marked this pull request as draft August 22, 2024 21:00
@Jaeyoung-Lim Jaeyoung-Lim marked this pull request as ready for review August 22, 2024 21:04
@Jaeyoung-Lim Jaeyoung-Lim added the Sim: gazebo Gazebo simulator (gz) label Aug 22, 2024
@hamishwillee
Copy link
Contributor

When this goes in, does that mean we will no longer support "Garden"? Does Harmonic work on Ubuntu 20.04?

We'll need some docs updates for this.

@Jaeyoung-Lim
Copy link
Member Author

Jaeyoung-Lim commented Aug 22, 2024

When this goes in, does that mean we will no longer support "Garden"?

Yes, even if we do we cannot support it further than Nov 2024 since it would be EOL

Does Harmonic work on Ubuntu 20.04?

I will find out

@dagar dagar merged commit b1dfe1d into main Aug 23, 2024
55 checks passed
@dagar dagar deleted the pr-gz-harmonic branch August 23, 2024 01:37
@hamishwillee
Copy link
Contributor

hamishwillee commented Aug 28, 2024

@Jaeyoung-Lim Should this backport to v1.15 too?

FYI, ROS docs call the humble/harmonic pairing risky: "- Possible, but use with caution. These combinations of ROS and Gazebo can be made to work together, but some effort is required."

Also, was macOS installer updated?
In https://docs.px4.io/main/en/dev_setup/dev_env_mac.html#macos-development-environment it says brew install px4-sim-gazebo

Docs currently cover both Humble and Foxy. However no package exists for the Foxy/Harmonic combination.
Should we just remove docs on Foxy in main (or stick with Gazebo there)? (@beniaminopozzan FYI)?

@bperseghetti
Copy link
Member

@Jaeyoung-Lim Should this backport to v1.15 too?

FYI, ROS docs call the humble/harmonic pairing risky: "- Possible, but use with caution. These combinations of ROS and Gazebo can be made to work together, but some effort is required."

Also, was macOS installer updated? In https://docs.px4.io/main/en/dev_setup/dev_env_mac.html#macos-development-environment it says brew install px4-sim-gazebo

Docs currently cover both Humble and Foxy. However no package exists for the Foxy/Harmonic combination. Should we just remove docs on Foxy in main (or stick with Gazebo there)? (@beniaminopozzan FYI)?

So, Foxy/Harmonic would not be a wise combination to use IMO. But we do have binary releases for supporting Humble/Harmonic and of course also Jazzy/Harmonic.

@bperseghetti
Copy link
Member

bperseghetti commented Aug 29, 2024

@dagar Probably should fix this to avoid risk of confusion during install: #23632

@beniaminopozzan
Copy link
Member

@hamishwillee the setup scripts (now) install

  • Gazebo Classic 11 for Ubuntu 20.04
  • Gazebo Garden for Ubuntu 21.3
  • Gazebo Harmonic for Ubuntu 22.04

ROS 2 Foxy users will be using Ubuntu 20.04 and therefore Gazebo Classic 11 so there is no way they end up getting the ROS 2 Foxy / Gazebo Harmonic pair by just using the setup script.

ROS 2 Foxy is already EOL so keeping the documentation for it an for Gazebo Garden, as long as their EOL status is pointed out, is not that bad.

@hamishwillee
Copy link
Contributor

Fixed by PX4/PX4-user_guide#3367

I ignore Ubuntu 21.3 - only mad people use older non LTS variants :-).

The recommendation is upgrade to the "supported version" - Gazebo Harmonic for Ubuntu 22.04. Foxy/Gazebo Classic instructions remain in the docs, but I note that Foxy is EOL ... so upgrading makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sim: gazebo Gazebo simulator (gz)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants