Add track metada informations #44
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the metadata field for track in "TrackStartEvent" event.
ThePedroo
added
enhancement
3 tasks
ThePedroo
force-pushed
the
main
branch
3 times, most recently
from
c4001fa to
b395a60
Compare
ThePedroo
force-pushed
the
main
branch
3 times, most recently
from
dbad65b to
355ca8e
Compare
ThePedroo
force-pushed
the
main
branch
6 times, most recently
from
3b2cb5d to
ad0df86
Compare
ThePedroo
force-pushed
the
main
branch
4 times, most recently
from
d8da381 to
b9063dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds a
metadatafield intotrackinTrackStartEventwith information about the playing file.Why
This allows the bot/client to be more aware of what's happening internally, also allows easier debugging of some audio quality issues. This is PR is connected with #42
Checkmarks
Additional information
There are issues on how sources like
httpwill have its bitrate calculated, as tillTrackEndEvent, the length is unknown due to leak of such calculations, which is done outside by FFmpeg.