Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add North Carolina Subsidized Child Care Assistance (SCCA) program #5575

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Add North Carolina Subsidized Child Care Assistance (SCCA) program #5575

wants to merge 18 commits into from
+2,867 −1

Conversation

myang1010
Copy link
Contributor

Fixes #5574

@codecov Codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (75cc11e) to head (54e6b07).
Report is 59 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #5575    +/-   ##
========================================
  Coverage   99.10%   99.10%            
========================================
  Files        2687     2706    +19     
  Lines       38934    39190   +256     
  Branches      170      172     +2     
========================================
+ Hits        38585    38841   +256     
  Misses        315      315            
  Partials       34       34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxGhenis MaxGhenis requested a review from DTrim99 February 11, 2025 01:04
PavelMakarchuk
PavelMakarchuk requested changes Feb 12, 2025
View reviewed changes
policyengine_us/parameters/gov/states/nc/ncdhhs/scca/disabled_age_limit.yaml Show resolved Hide resolved
policyengine_us/variables/gov/states/nc/ncdhhs/scca/entry/nc_scca_entry_income_eligible.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/nc/ncdhhs/scca/nc_scca_countable_income.py Show resolved Hide resolved
policyengine_us/variables/gov/states/nc/ncdhhs/scca/nc_scca_fpl_rate.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/nc/ncdhhs/scca/nc_scca_parent_fee.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/nc/ncdhhs/scca/nc_scca_age_group.py Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/nc/ncdhhs/scca/childcare_market_rates.yaml Outdated
@@ -0,0 +1,912 @@
description: North Carolina Subsidized Child Care Market Rates for Child Care Centers - Effective 10-1-2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: North Carolina Subsidized Child Care Market Rates for Child Care Centers - Effective 10-1-2023
description: North Carolina set the following Subsidized Child Care Market Rates for Child Care Centers.

policyengine_us/variables/gov/states/nc/ncdhhs/scca/nc_scca.py
from policyengine_us.model_api import *


class nc_scca(Variable):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add this to the list of benefits in household_state_benefits.yaml

policyengine_us/variables/gov/states/nc/ncdhhs/scca/nc_scca_age_group.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/nc/ncdhhs/scca/nc_scca_child_age_eligible.py Outdated Show resolved Hide resolved
@myang1010
Copy link
Contributor Author

@PavelMakarchuk , thanks for the review! I've made changes based on your feedback and have a couple of questions:

  1. What’s the rule of thumb for using .this_year, and when should it be avoided?
  2. Using min_(ages) in policyengine_us/variables/gov/states/nc/ncdhhs/scca/nc_scca_fpl_rate.py causes unit and integration tests to fail. Any thoughts on how to fix this if I have to use min_()?"

@PavelMakarchuk
Copy link
Collaborator

@PavelMakarchuk , thanks for the review! I've made changes based on your feedback and have a couple of questions:

  1. What’s the rule of thumb for using .this_year, and when should it be avoided?
  2. Using min_(ages) in policyengine_us/variables/gov/states/nc/ncdhhs/scca/nc_scca_fpl_rate.py causes unit and integration tests to fail. Any thoughts on how to fix this if I have to use min_()?"

@PavelMakarchuk , thanks for the review! I've made changes based on your feedback and have a couple of questions:

  1. What’s the rule of thumb for using .this_year, and when should it be avoided?
  2. Using min_(ages) in policyengine_us/variables/gov/states/nc/ncdhhs/scca/nc_scca_fpl_rate.py causes unit and integration tests to fail. Any thoughts on how to fix this if I have to use min_()?"

@myang1010 thanks for flagging this,

  1. I think the easiest way to see this is:.this_year should be applied when converting yearly float or int values to monthly values. For example, if we have an age value calculated yearly, where age = 12, applying .this_year will convert it to a monthly value (1 in this case). However, this doesn't apply to boolean values since they remain 0 or 1, regardless of time scale. The same applies to enumerated variables, as these values are not broken down into monthly equivalents.

  2. you are right, we should use min as the age is a person level we want only the spmunit level value

@myang1010
Copy link
Contributor Author

@myang1010 thanks for flagging this,

  1. I think the easiest way to see this is:.this_year should be applied when converting yearly float or int values to monthly values. For example, if we have an age value calculated yearly, where age = 12, applying .this_year will convert it to a monthly value (1 in this case). However, this doesn't apply to boolean values since they remain 0 or 1, regardless of time scale. The same applies to enumerated variables, as these values are not broken down into monthly equivalents.
  2. you are right, we should use min as the age is a person level we want only the spmunit level value

Thank you @PavelMakarchuk for the reply. That's very helpful! Please let me know if there's anything else needs to be addressed. Thanks!

PavelMakarchuk
PavelMakarchuk requested changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should address the test

policyengine_us/variables/gov/states/nc/ncdhhs/scca/nc_scca_fpl_rate.py Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/nc/ncdhhs/scca/disabled_age_limit.yaml Show resolved Hide resolved
policyengine_us/variables/gov/states/nc/ncdhhs/scca/nc_scca_fpl_rate.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/nc/ncdhhs/scca/nc_scca_fpl_rate.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/nc/ncdhhs/scca/nc_scca_fpl_rate.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/nc/ncdhhs/scca/nc_scca_fpl_rate.py Outdated Show resolved Hide resolved
PavelMakarchuk
PavelMakarchuk requested changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, some minor formatting comments

policyengine_us/parameters/gov/states/nc/ncdhhs/scca/childcare_market_rates.yaml
@@ -0,0 +1,912 @@
description: North Carolina set the following Subsidized Child Care Market Rates for Child Care Centers.
metadata:
unit: currency-USD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a label?

policyengine_us/parameters/gov/household/household_state_benefits.yaml
@@ -17,6 +17,8 @@ values:
- ca_capi
# Nebraska benefits
- ne_child_care_subsidies
# North Carolina benefits
- nc_scca
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add this in 2024 since the subsidized rate only applies starting on 2023-10 - if we try to compute the nc_scca in 2023 it would break

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple of integration tests for 2023-01 and encountered no errors. To be safe, I've moved them to 2024-01 like suggested.

policyengine_us/parameters/gov/states/nc/ncdhhs/scca/entry/income_rate_by_child_age.yaml Outdated
@@ -0,0 +1,20 @@
description: North Carolina Subsidized Child Care Assistance program's maximum initial income limits differ depending on the age of the child
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: North Carolina Subsidized Child Care Assistance program's maximum initial income limits differ depending on the age of the child
description: North Carolina limits the Subsidized Child Care Assistance program initially to filers with income below this percentage of federal poverty guidelines, based on the age of the dependent.

policyengine_us/parameters/gov/states/nc/ncdhhs/scca/infant_age_limit.yaml Outdated
@@ -0,0 +1,10 @@
description: North Carolina categorizes children under below age as Infant group in its Subsidized Child Care Assistance program.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: North Carolina categorizes children under below age as Infant group in its Subsidized Child Care Assistance program.
description: North Carolina categorizes children below age as infants under the Subsidized Child Care Assistance program.

policyengine_us/parameters/gov/states/nc/ncdhhs/scca/infant_age_limit.yaml Outdated
Comment on lines 4 to 5
- title: Subsidized Child Care Market Rates for Child Care Centers - Effective 10-1-2023
href: https://ncchildcare.ncdhhs.gov/Portals/0/documents/pdf/M/Market_Rates_Centers_Eff_10-1.pdf?ver=9w52alSPhmrmo0N9gGVMEw%3d%3d
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove references if they don't specifically point to the policy parameter which is mentioned in the yaml file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to remove this reference in other age limit files also, Eg, preschool_age_lower, toddler_age_limit, etc.?

policyengine_us/variables/gov/states/nc/ncdhhs/scca/nc_scca_age_group.py Outdated
from policyengine_us.model_api import *


class AgeGroup(Enum):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class AgeGroup(Enum):
class NCSCCAAgeGroup(Enum):

@myang1010
Copy link
Contributor Author

@PavelMakarchuk, I removed the toddler_age_limit reference in the latest commit since it's similar to infant_age_limit. Let me know if anything else needs changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxGhenis MaxGhenis MaxGhenis left review comments

@PavelMakarchuk PavelMakarchuk PavelMakarchuk requested changes

@DTrim99 DTrim99 DTrim99 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

North Carolina Subsidized Child Care Assistance(SCCA) program
4 participants
@myang1010 @PavelMakarchuk @MaxGhenis @DTrim99