Add North Carolina Subsidized Child Care Assistance (SCCA) program

[myang1010]

Fixes #5574

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (75cc11e) to head (54e6b07).
Report is 59 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #5575    +/-   ##
========================================
  Coverage   99.10%   99.10%            
========================================
  Files        2687     2706    +19     
  Lines       38934    39190   +256     
  Branches      170      172     +2     
========================================
+ Hits        38585    38841   +256     
  Misses        315      315            
  Partials       34       34            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[PavelMakarchuk]

Suggested change

	description: North Carolina Subsidized Child Care Market Rates for Child Care Centers - Effective 10-1-2023
	description: North Carolina set the following Subsidized Child Care Market Rates for Child Care Centers.

[PavelMakarchuk]

could we add this to the list of benefits in household_state_benefits.yaml

[myang1010]

@PavelMakarchuk , thanks for the review! I've made changes based on your feedback and have a couple of questions:

1. What’s the rule of thumb for using .this_year, and when should it be avoided?
2. Using min_(ages) in policyengine_us/variables/gov/states/nc/ncdhhs/scca/nc_scca_fpl_rate.py causes unit and integration tests to fail. Any thoughts on how to fix this if I have to use min_()?"

[PavelMakarchuk]

@PavelMakarchuk , thanks for the review! I've made changes based on your feedback and have a couple of questions:

1. What’s the rule of thumb for using .this_year, and when should it be avoided?
2. Using min_(ages) in policyengine_us/variables/gov/states/nc/ncdhhs/scca/nc_scca_fpl_rate.py causes unit and integration tests to fail. Any thoughts on how to fix this if I have to use min_()?"

@PavelMakarchuk , thanks for the review! I've made changes based on your feedback and have a couple of questions:

1. What’s the rule of thumb for using .this_year, and when should it be avoided?
2. Using min_(ages) in policyengine_us/variables/gov/states/nc/ncdhhs/scca/nc_scca_fpl_rate.py causes unit and integration tests to fail. Any thoughts on how to fix this if I have to use min_()?"

@myang1010 thanks for flagging this,

1. I think the easiest way to see this is:.this_year should be applied when converting yearly float or int values to monthly values. For example, if we have an age value calculated yearly, where age = 12, applying .this_year will convert it to a monthly value (1 in this case). However, this doesn't apply to boolean values since they remain 0 or 1, regardless of time scale. The same applies to enumerated variables, as these values are not broken down into monthly equivalents.

2. you are right, we should use min as the age is a person level we want only the spmunit level value

[myang1010]

@myang1010 thanks for flagging this,

1. I think the easiest way to see this is:.this_year should be applied when converting yearly float or int values to monthly values. For example, if we have an age value calculated yearly, where age = 12, applying .this_year will convert it to a monthly value (1 in this case). However, this doesn't apply to boolean values since they remain 0 or 1, regardless of time scale. The same applies to enumerated variables, as these values are not broken down into monthly equivalents.
2. you are right, we should use min as the age is a person level we want only the spmunit level value

Thank you @PavelMakarchuk for the reply. That's very helpful! Please let me know if there's anything else needs to be addressed. Thanks!

[PavelMakarchuk]

I think this should address the test

[PavelMakarchuk]

Looks great, some minor formatting comments

[PavelMakarchuk]

could you add a label?

[PavelMakarchuk]

I think we need to add this in 2024 since the subsidized rate only applies starting on 2023-10 - if we try to compute the nc_scca in 2023 it would break

[myang1010]

I added a couple of integration tests for 2023-01 and encountered no errors. To be safe, I've moved them to 2024-01 like suggested.

[PavelMakarchuk]

Suggested change

	description: North Carolina Subsidized Child Care Assistance program's maximum initial income limits differ depending on the age of the child
	description: North Carolina limits the Subsidized Child Care Assistance program initially to filers with income below this percentage of federal poverty guidelines, based on the age of the dependent.

[PavelMakarchuk]

Suggested change

	description: North Carolina categorizes children under below age as Infant group in its Subsidized Child Care Assistance program.
	description: North Carolina categorizes children below age as infants under the Subsidized Child Care Assistance program.

[PavelMakarchuk]

Could you remove references if they don't specifically point to the policy parameter which is mentioned in the yaml file

[myang1010]

Do you want me to remove this reference in other age limit files also, Eg, preschool_age_lower, toddler_age_limit, etc.?

[PavelMakarchuk]

Suggested change

	class AgeGroup(Enum):
	class NCSCCAAgeGroup(Enum):

[myang1010]

@PavelMakarchuk, I removed the toddler_age_limit reference in the latest commit since it's similar to infant_age_limit. Let me know if anything else needs changes.