-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add North Carolina Subsidized Child Care Assistance (SCCA) program #5575
Open
myang1010
wants to merge
19
commits into
PolicyEngine:master
Choose a base branch
from
myang1010:myang1010/issue5574
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
4853253
basic files and tructures for scca
myang1010 bed64a9
remove some unnecessary files and optimize some formula
myang1010 9a33ad1
update county names for market rates and add in some unit tests
myang1010 b07d096
adding more valid tests
myang1010 da27dbb
refactor variables and add more tests
myang1010 e08fa2f
added the first integration test, need to clean up
myang1010 560ab66
refactored age group and added more integration tests
myang1010 abb4f8a
found and fix some defects in the code, added more tests, need to cle…
myang1010 914d18a
Extract key age limits to params and optimize some code blocks
myang1010 360fe5f
simplify age check condistions
myang1010 06ef3cb
cleaned up code, formatted files and updated file resources
myang1010 725e668
bring back makefile
myang1010 a199b85
updated reference sources and make them more specific
myang1010 f3ff921
correct typos
myang1010 fa70697
address review feedback
myang1010 480c3ed
address review feedback
myang1010 e80dc9a
fix the failed test
myang1010 54e6b07
address review feedback
myang1010 0f71d4b
address feedback review, added statutory reference for the infant age…
myang1010 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
- bump: minor | ||
changes: | ||
added: | ||
- Implemented North Carolina Subsidized Child Care Assistance (SCCA) program and entry eligibility calculations. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please add content here indicating how you produced the market rates yaml file, given its size and complexity. if you used a python script please include it as well. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
# North Carolina Subsidized Child Care Assistance Program |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to add this in 2024 since the subsidized rate only applies starting on 2023-10 - if we try to compute the
nc_scca
in 2023 it would breakThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a couple of integration tests for 2023-01 and encountered no errors. To be safe, I've moved them to 2024-01 like suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uncomment