Handle a baseURI of null #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `ownerDocument.baseURI` is null (detached document, maybe some other cases), `new URL(url, baseURI)` will throw. Only use `new URL` when `baseURI` is not null.
On second thought, you really only need `new URL`. `Polymer.ResolveUrl.resolveUrl` is just doing the same thing as this.
| @@ -396,8 +396,11 @@ | |||
| }, | |||
|
|
|||
| _resolveSrc: function(testSrc) { | |||
| var baseURI = /** @type {string} */(this.ownerDocument.baseURI); | |||
There was a problem hiding this comment.
@type isn't needed anymore?
|
This will cause #86 again when the URL isn't resolved. How about |
|
I don't believe this is applicable anymore with the latest in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
ownerDocument.baseURIis null (detached document, maybe some other cases),new URL(url, baseURI)will throw.Only use
new URLwhenbaseURIis not null.