Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle a baseURI of null #91

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle a baseURI of null #91

wants to merge 2 commits into from

Commits on Aug 19, 2016

  1. Handle a baseURI of null 

    When `ownerDocument.baseURI` is null (detached document, maybe some other cases), `new URL(url, baseURI)` will throw.
Only use `new URL` when `baseURI` is not null.
    @dfreedm
    dfreedm authored Aug 19, 2016
    Configuration menu
    Copy the full SHA
    cd49350 View commit details
    Browse the repository at this point in the history

  2. Just use new URL 

    On second thought, you really only need `new URL`. `Polymer.ResolveUrl.resolveUrl` is just doing the same thing as this.
    @dfreedm
    dfreedm authored Aug 19, 2016
    Configuration menu
    Copy the full SHA
    897784c View commit details
    Browse the repository at this point in the history