This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
Force consistent capitalization of Polymer/ PolymerElements and PolymerLabs in bower.json #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erLabs in bower.json Fixes #47
| @@ -147,5 +147,5 @@ async function cleanupTravisConfig(element: ElementRepo): Promise<void> { | |||
| register({ | |||
| name: 'travis', | |||
| pass: cleanupTravisConfig, | |||
| runsByDefault: true, | |||
| runsByDefault: false, | |||
There was a problem hiding this comment.
This change seems unrelated. Intentional?
There was a problem hiding this comment.
Intentional. We never landed all of the travis fixups, which still need some hand-fixing afaik
|
LGTM with the one nit. |
|
LGTM! |
|
Leaving this open for now, I don't want to potentially break the world on a friday afternoon, will wait to monday to merge and run it against our elements when I'll have time to do it carefully |
|
Good choice @rictic! :) |
|
I have also created Polymer/polymer#3844 which is related |
|
Dear Polymer Team, Maybe you don't have time because you focus on Polymer 2.x (which I'm looking forward) or you have some technical concerns to do this automated. I'm really stuck with this in Polymer 1.x and would also volunteer to create manual pull requests for each of the PolymerElements subprojects that are inconsistent in their "main" dependencies. I counted and documented them in #47 and they are only 22 which is kind of doable |
This was referenced Jan 19, 2017
This was referenced Apr 21, 2017
Merged
bartolom
added a commit
to bartolom/app-route
that referenced
this pull request
Jul 31, 2017
This is a similar pull request to PolymerElements#174. I assume that when you merged your 2.0-preview branch into master, you have overwritten the changes again. This time I also covered the "devDependencies". Below is a copy-and-paste of the rational of this change: This pull requests want to make this Polymer element consistent with the majority of other Polymer elements. The uppercase version "PolymerElements" is closer to real name of the github project name, like presented in the git URL. The use of mixed case does not seem to have an effect on bower and JavaScript projects. But other languages like Java are more picky and would benefit from consistency. This pull request is a manual follow up of PolymerLabs/tedium#47 and PolymerLabs/tedium#48 which try to do this in an automated way, but are stuck.
bartolom
added a commit
to bartolom/app-pouchdb
that referenced
this pull request
Jul 31, 2017
This is a similar pull request like PolymerElements#46 which I closed. The polymer team did the 2.0-preview merge a while ago and this pull request is against the master branch. The rational for this change: This pull request wants to make this Polymer element consistent with the majority of other Polymer elements. The uppercase version "PolymerElements" and "Polymer" is closer to real name of the github project name, like presented in the git URL. The use of mixed case does not seem to have an effect on bower and JavaScript projects. But other languages like Java are more picky and would benefit from consistency. I'm mostly concerned with the bower "Main" dependencies, but as I have changed this file already I also fixed this in the devDependencies This pull request is a manual follow up of PolymerLabs/tedium#47 and PolymerLabs/tedium#48 which try to do this in an automated way, but are stuck.
bartolom
added a commit
to bartolom/iron-icons
that referenced
this pull request
Jul 31, 2017
This pull requests want to make this Polymer element consistent with the majority of other Polymer elements. The uppercase version "PolymerElements" is closer to real name of the github project name, like presented in the git URL. The use of mixed case does not seem to have an effect on bower and JavaScript projects. But other languages like Java are more picky and would benefit from consistency. This pull request is a manual follow up of PolymerLabs/tedium#47 and PolymerLabs/tedium#48 which try to do this in an automated way, but are stuck.
bartolom
added a commit
to bartolom/iron-pages
that referenced
this pull request
Jul 31, 2017
This pull requests want to make this Polymer element consistent with the majority of other Polymer elements. The uppercase version "PolymerElements" is closer to real name of the github project name, like presented in the git URL. The use of mixed case does not seem to have an effect on bower and JavaScript projects. But other languages like Java are more picky and would benefit from consistency. This pull request is a manual follow up of PolymerLabs/tedium#47 and PolymerLabs/tedium#48 which try to do this in an automated way, but are stuck.
bartolom
added a commit
to bartolom/iron-ajax
that referenced
this pull request
Jul 31, 2017
This pull request is similar to PolymerElements#251 which I have closed. This updated version not only fixes the main dependency in the 1.x variant but also all "devDependencies" as well. The rational for this pull request is: This pull requests want to make this Polymer element consistent with the majority of other Polymer elements. The uppercase version "PolymerElements" is closer to real name of the github project name, like presented in the git URL. The use of mixed case does not seem to have an effect on bower and JavaScript projects. But other languages like Java are more picky and would benefit from consistency. This pull request is a manual follow up of PolymerLabs/tedium#47 and PolymerLabs/tedium#48 which try to do this in an automated way, but are stuck.
bartolom
added a commit
to bartolom/iron-behaviors
that referenced
this pull request
Jul 31, 2017
This pull request is similar to PolymerElements#72 but is based on the current master branch rather then the old 2.0-preview The rational for this change is: This pull request wanta to make this Polymer element consistent with the majority of other Polymer elements. The uppercase version "PolymerElements" is closer to real name of the github project name, like presented in the git URL. The use of mixed case does not seem to have an effect on bower and JavaScript projects. But other languages like Java are more picky and would benefit from consistency. I'm mostly concerned with the bower "Main" dependencies, but as I have changed this file already I also fixed this in the devDependencies This pull request is a manual follow up of PolymerLabs/tedium#47 and PolymerLabs/tedium#48 which try to do this in an automated way, but are stuck.
bartolom
added a commit
to bartolom/iron-demo-helpers
that referenced
this pull request
Jul 31, 2017
This is a follow up of PolymerElements#58 which was on the old 2.0-preview branch. This pull request wants to make this Polymer element consistent with the majority of other Polymer elements. The uppercase version "PolymerElements" and "Polymer" is closer to real name of the github project name, like presented in the git URL. The use of mixed case does not seem to have an effect on bower and JavaScript projects. But other languages like Java are more picky and would benefit from consistency. This pull request is a manual follow up of PolymerLabs/tedium#47 and PolymerLabs/tedium#48 which try to do this in an automated way, but are stuck.
bartolom
added a commit
to bartolom/paper-material
that referenced
this pull request
Jul 31, 2017
This pull requests want to make this Polymer element consistent with the majority of other Polymer elements. The uppercase version "PolymerElements" is closer to real name of the github project name, like presented in the git URL. The use of mixed case does not seem to have an effect on bower and JavaScript projects. But other languages like Java are more picky and would benefit from consistency. This pull request is a manual follow up of PolymerLabs/tedium#47 and PolymerLabs/tedium#48 which try to do this in an automated way, but are stuck.
bartolom
added a commit
to bartolom/firebase-element
that referenced
this pull request
Jul 31, 2017
This pull requests want to make this Polymer element consistent with the majority of other Polymer elements. The uppercase version "Polymer" is closer to real name of the github project name, like presented in the git URL. The use of mixed case does not seem to have an effect on bower and JavaScript projects. But other languages like Java are more picky and would benefit from consistency. This pull request is a manual follow up of PolymerLabs/tedium#47 and PolymerLabs/tedium#48 which try to do this in an automated way, but are stuck.
bartolom
added a commit
to bartolom/google-chart
that referenced
this pull request
Jul 31, 2017
This pull requests want to make this Polymer element consistent with the majority of other Polymer elements. The uppercase version "PolymerLabs" is closer to real name of the github project name, like presented in the git URL. The use of mixed case does not seem to have an effect on bower and JavaScript projects. But other languages like Java are more picky and would benefit from consistency. This pull request is a manual follow up of PolymerLabs/tedium#47 and PolymerLabs/tedium#48 which try to do this in an automated way, but are stuck.
bartolom
added a commit
to bartolom/google-feeds
that referenced
this pull request
Jul 31, 2017
This pull requests want to make this Polymer element consistent with the majority of other Polymer elements. The uppercase version "Polymer" is closer to real name of the github project name, like presented in the git URL. The use of mixed case does not seem to have an effect on bower and JavaScript projects. But other languages like Java are more picky and would benefit from consistency. This pull request is a manual follow up of PolymerLabs/tedium#47 and PolymerLabs/tedium#48 which try to do this in an automated way, but are stuck.
bartolom
added a commit
to bartolom/polymerfire
that referenced
this pull request
Jul 31, 2017
This pull requests want to make this Polymer element consistent with the majority of other Polymer elements. The uppercase version "Polymer" is closer to real name of the github project name, like presented in the git URL. The use of mixed case does not seem to have an effect on bower and JavaScript projects. But other languages like Java are more picky and would benefit from consistency. This pull request is a manual follow up of PolymerLabs/tedium#47 and PolymerLabs/tedium#48 which try to do this in an automated way, but are stuck.
wesalvaro
pushed a commit
to GoogleWebComponents/google-chart
that referenced
this pull request
Aug 1, 2017
This pull requests want to make this Polymer element consistent with the majority of other Polymer elements. The uppercase version "PolymerLabs" is closer to real name of the github project name, like presented in the git URL. The use of mixed case does not seem to have an effect on bower and JavaScript projects. But other languages like Java are more picky and would benefit from consistency. This pull request is a manual follow up of PolymerLabs/tedium#47 and PolymerLabs/tedium#48 which try to do this in an automated way, but are stuck.
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47
/cc @abdonrd