Introduce Features #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcooney
force-pushed
the
kevin/features
branch
4 times, most recently
from
2f449b1 to
d54988d
Compare
Features can be initally disabled or disabled, and can be configured to be enabled via Shuffleboard. Commands can be configured to be scheduled only if all controlling features are enabled by using Features.whenAllEnabled(). This allows us to add functionality to the robot that might not be fully tested by having the functionality disabled by default.
- Reduce code duplication in asSupplier() implementations - Remove support for SmartDashboard - Remove 'enabled' field and enabled() method from Feature
Evalating the features inside the command was problematic, since replacing a Command expression with an expression that could return a feature-controlled flag would change the requirements of the resulting Command.
cuttestkittensrule
requested changes
Apr 28, 2024
Comment on lines
+41
to
+43
| public void resetFeatures() { | ||
| FakeFeatures.reset(registry); | ||
| } |
There was a problem hiding this comment.
Since you are scheduling commands in these tests, you should make sure all of them are canceled by running CommandScheduler.cancelAll()
Comment on lines
+65
to
+72
| static class SimpleCommand extends Command { | ||
| boolean ran = false; | ||
|
|
||
| @Override | ||
| public void execute() { | ||
| ran = true; | ||
| } | ||
| } |
There was a problem hiding this comment.
This command will never finish, as the command will only finish if Command.isFinished() returns false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features can be initally disabled or disabled, and can be configured to be enabled via Shuffleboard. Commands can be configured to be scheduled only if all controlling features are enabled by using Features.whenAllEnabled().
This allows us to add functionality to the robot that might not be fully tested by having the functionality disabled by default.