Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure correct dtype of "reverse" column #1525

Merged
merged 11 commits into from
Feb 4, 2025

Conversation

FabianHofmann
Copy link
Contributor

@FabianHofmann FabianHofmann commented Feb 3, 2025

The current CI fails because of mixed dtypes in the "reverse" column. This should make sure that "reverse" is always a boolean.

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

  • master failed in: no_logs_found
  • fix-link-reverse-dtype failed in: no_logs_found

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing fix-link-reverse-dtype (1aa133f) with master (91ddafd).
Branch is 11 commits ahead and 0 commits behind.
Last updated on 2025-02-04 16:27:45 CET.

Copy link
Member

@lkstrp lkstrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !
I was just looking into this. But why is this only a problem for the PyPSA master and not 0.32.1 ?

@FabianHofmann FabianHofmann merged commit 590b684 into master Feb 4, 2025
12 checks passed
@FabianHofmann FabianHofmann deleted the fix-link-reverse-dtype branch February 4, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants