Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure correct dtype of "reverse" column #1525

Merged
merged 11 commits into from
Feb 4, 2025
Merged

fix: ensure correct dtype of "reverse" column #1525

Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9315bf9
fix: ensure correct dtype of "reverse" column
FabianHofmann Feb 3, 2025
8ec2224
Merge branch 'master' into fix-link-reverse-dtype
lkstrp Feb 3, 2025
7e12236
Merge branch 'master' into fix-link-reverse-dtype
lkstrp Feb 3, 2025
df6490a
apply boolean dtype to reverse column in perfect-foresight
FabianHofmann Feb 3, 2025
2bdb3c6
reinsert objective check
FabianHofmann Feb 3, 2025
7dd41d7
fix: improve selection of bidirectionals
FabianHofmann Feb 3, 2025
82e46b5
fix: relax condition on sanitizing "reversed" column
FabianHofmann Feb 3, 2025
71bc7cc
revert some unneeded changes
FabianHofmann Feb 3, 2025
745fdf9
debug: print dataframes in summary (to be reverted)
FabianHofmann Feb 4, 2025
f92a67a
filter empty dfs in make summary
FabianHofmann Feb 4, 2025
1aa133f
use highs-simplex instead of highs-default for ci
FabianHofmann Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/prepare_sector_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4378,8 +4378,8 @@ def lossy_bidirectional_links(n, carrier, efficiencies={}):
rev_links["reversed"] = True
rev_links.index = rev_links.index.map(lambda x: x + "-reversed")

n.links["reversed"] = n.links.get("reversed", False)
n.links = pd.concat([n.links, rev_links], sort=False)
n.links["reversed"] = n.links["reversed"].fillna(False).infer_objects(copy=False)
n.links["length_original"] = n.links["length_original"].fillna(n.links.length)

# do compression losses after concatenation to take electricity consumption at bus0 in either direction
Expand Down
Loading