-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to support new LeetCode UI (regular problems) #464
base: dev
Are you sure you want to change the base?
Conversation
New Year's push
"look" is missing in the sentence "Your LeetHub portfolio could like this!"
Added leading zeros to titles
* Update gfg.js Fix QasimWani#307 * Review update * 0.0.9 * Update `output` window `querySelector` The old selector element gets removed from the DOM when the output window close is closed.
So I've worked more with
There are still many features to work on though, including
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅✅
awesome stuff @Ahmed-Shukri02. Could you perhaps also add the spinner? No worries if not, i can add that functionality. |
@QasimWani I've just added the spinner feature for the new UI: I've yet to work on the explore section though, and on some questions when I want to upload I get a 422 status code from github's API: With the response message:
This is a question-consistent thing, not a random occurrence. It's also present on both versions of leetcode. What do you think may be the cause of this? |
Hi @QasimWani, can this update be merged into main since a lot of people are waiting for the new update? |
@Ahmed-Shukri02 can you make a fork for people to use? The author doesn't seem to be responding to any pull requests. |
I have a public fork that you can use now. I've left instructions on using this on your local machine in this comment |
Hey sorry guys. Will check this over the weekend and hopefully have it merged before Monday. Thanks for being patient with me! |
Thanks @Ahmed-Shukri02 for your fantastic work on the extension. I really liked how you focused on adding support for the new design and I hope for your changes to be merged soon ^^ I found an issue to highlight, If I resubmit another solution to a previous problem, it isn't always pushed to the repo. It'll only be pushed if I refresh the page before the resubmission. And sometimes it shows the green check mark without pushing. |
I feel like this could be a separate bug ticket. At least getting this PR merged would get the extension compatible with the new UI. |
Thanks @ibnsamy96 for the good catch. Since in the new UI, you could switch tabs and revisit the accepted page, I didn't want LeetHub to upload to github multiple times, so I added a boolean that toggles on submission. Once submitted, the boolean would cause LeetHub to stop checking for accepted submissions by exiting from the function early: This was really just a quick fix and so meant that the script had to be reloaded for every submission. This could be considered as a bug or a feature I guess. Either way, I agree with @codentacos that we should try and get this merged as soon as possible then maybe file an issue |
Any update's about when this can get merged? @QasimWani |
Any updates? Would be nice to have this working again. |
any updates on this? it was my first time using the extension, and after linking I was looking for the upload button, but couldn't figure out how to. when I checked the issues, then I realized that it is an issue because of LeetHub's UI change 😣 |
@QasimWani Please Merge this , Its fixed in this PR , I checked |
@QasimWani, could you merge it? |
I feel like this repo needs an additional maintainer who can merge PR's |
Another 2 issues open, that are related to this PR. #503 this error, and the 3 before, would be solved by this PR |
Not a good sign 😅 https://twitter.com/qasim31wani/status/1617170664271613955?s=20 We just need this merged, another maintainer seems like a great idea if Qasim is open to it |
I have seen before when a project is no longer maintained someone fork's it and maintains a new version of it. Something along those lines. Although if he needs motivation he could charge $1 a month for licenses to use it then he gets $30K MRR. Would that be motivation enough? 👀 |
@codentacos yes I think a fork is a good idea, if he is not able to maintain or willing to add access for others. It's too bad. |
hey guys. sorry just saw this. Am talking to few OG LeetHub developers to take most of the responsibility of my shoulders. should have an update the next few days! |
Hey @QasimWani. Let us know if you're looking for any help, we all can give a hand |
Have it fixed? |
LeetHub currently does not work with the new UI used by LeetCode. This is due to the fact that document queries no longer work now that classnames, ids and components are different. This is a fix to part of the problem and still needs developing, hence this being on the dev branch.
The only file I updated (other than a change in extension name for development in
manifest.json
) isleetcode.js
. There are 2 new functions added as well as an update toloader()
(not completed),parseQuestion()
andparseStats()
:RegExKeyMatch() // Line 442
parsePercentileNew() // Line 548
The function of these are explained in the code. Other than these files, nothing was updated and so the updates shown on the PR are a reflection of previous updates in main
The result of this is that LeetHub can now parse question details and submission statistics from both the old (left) and new (right) UI.
The formatting for the question description is different when using the new UI (text format compared to html), and so may need further formatting or a work-around.
This by no means completely fixes the issue but is what I'd call first steps in accommodating the new UI. I'm currently working on other functions such as
getProblemNameSlug()
andparseCode()
to support this but first need to check if the current fixes are good or not.