Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of BackendProperties (BackendV1) in transpiler pipeline #13722

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ElePT
Copy link
Contributor

@ElePT ElePT commented Jan 22, 2025

Summary

This PR removes the following uses of BackendProperties deprecated in #13719:

  • backend_prop input argument in DenseLayout
  • properties input argument in VF2Layout
  • properties input argument in VF2PostLayout
  • backend_props input argument in UnitarySynthesis
  • backend_properties in PassManagerConfig
  • backend_properties in generate_routing_passmanager
  • backend_properties in generate_translation_passmanager
  • backend_properties in Target.from_configuration

as well as the previously deprecated input arguments of transpile, generate_preset_pass_manager.

Details and comments

Currently on hold as it contains the changes from #13706, should be rebased after it's merged.

Contributes to #13708.

@ElePT ElePT added the on hold Can not fix yet label Jan 22, 2025
@ElePT ElePT requested review from alexanderivrii, ShellyGarion and a team as code owners January 22, 2025 16:52
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@ElePT ElePT changed the title Remove v1 props transpiler Remove use of BackendProperties (BackendV1) in transpiler pipeline Jan 22, 2025
@ElePT ElePT added this to the 2.0.0 milestone Jan 22, 2025
@ElePT ElePT added the Changelog: Removal Include in the Removed section of the changelog label Jan 22, 2025
@coveralls
Copy link

coveralls commented Jan 22, 2025

Pull Request Test Coverage Report for Build 13201774669

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 6 files are covered.
  • 94 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.08%) to 88.532%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 93.09%
qiskit/providers/models/backendproperties.py 1 94.74%
crates/qasm2/src/lex.rs 3 92.73%
qiskit/transpiler/preset_passmanagers/builtin_plugins.py 5 95.69%
qiskit/transpiler/passes/layout/vf2_post_layout.py 10 80.32%
qiskit/providers/backend_compat.py 16 84.21%
qiskit/transpiler/target.py 58 84.32%
Totals Coverage Status
Change from base Build 13201696901: -0.08%
Covered Lines: 79185
Relevant Lines: 89442

💛 - Coveralls

@ElePT ElePT force-pushed the remove-v1-props-transpiler branch from f0958f1 to 25bf326 Compare February 7, 2025 14:24
@ElePT ElePT removed the on hold Can not fix yet label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants