Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduce bug in qrexec tests #661

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

DemiMarie
Copy link
Contributor

The qrexec tests are broken and fail intermittently. This patch makes the bug obvious: by adding a sleep, it causes the test to fail right away, reliably.

The qrexec tests are broken and fail intermittently.  This patch makes
the bug obvious: by adding a sleep, it causes the test to fail right
away, reliably.
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.72%. Comparing base (5de215d) to head (87f187d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
- Coverage   69.79%   69.72%   -0.07%     
==========================================
  Files          58       58              
  Lines       12546    12546              
==========================================
- Hits         8756     8748       -8     
- Misses       3790     3798       +8     
Flag Coverage Δ
unittests 69.72% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marmarek
Copy link
Member

I don't see any failure with this PR (but not QubesOS/qubes-core-qrexec#186): https://openqa.qubes-os.org/tests/129865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants