Two changes related to libvirt xml #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "nomodeset" option is a startup time optimization for the most common case, especially for HVM. Besides saving some drivers initialization for emulated VGA, it also prevents Xorg probing the device, plymouth trying to draw something there etc. But when real GPU is attached, it is harmful. Previously one needed set no-default-kernelopts feature, and then manually set all the options that were there (skipping nomodeset). Add an automatic filtering of the nomodeset option. And add an extra control via 'no-nomodeset' feature - to allow explicitly enabling or disabling this filtering too - regardless of attaching GPU. Fixes QubesOS/qubes-issues#9792
The libvirt xml already includes device class, there is no need to access sysfs for that.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
==========================================
- Coverage 69.79% 69.73% -0.06%
==========================================
Files 58 58
Lines 12546 12550 +4
==========================================
- Hits 8756 8752 -4
- Misses 3790 3798 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Feb 23, 2025
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025022311-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update
Failed tests9 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/129058#dependencies 15 fixed
Unstable testsPerformance TestsPerformance degradation:15 performance degradations
Remaining performance tests:57 tests
|
This was referenced Feb 23, 2025
When using a HVM with a GUI via stubdomain, that GUI agent should connect to the appropriate guivm. It is dom0 by default, so it works in a common case, but if somebody uses non-dom0 for GUI, then the parameter is missing. Passing through the parameter is already implemented in libvirt, libxl and QEMU. But setting it in the libvirt xml in the first place was missing. Fixes QubesOS/qubes-issues#9385
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for more details.
Fixes QubesOS/qubes-issues#9385
Fixes QubesOS/qubes-issues#9792