Support ptyxis in qubes-run-terminal #546

legoktm · 2025-01-14T13:54:08Z

Fedora 41 defaults to using ptyxis as its terminal instead of gnome-terminal. It also works correctly in dispVMs without needing any special --wait handling.

codecov · 2025-01-14T14:10:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.57%. Comparing base (74d07bb) to head (9c4d5ce).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #546   +/-   ##
=======================================
  Coverage   70.57%   70.57%           
=======================================
  Files           3        3           
  Lines         469      469           
=======================================
  Hits          331      331           
  Misses        138      138

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qubesos-bot · 2025-01-17T07:01:18Z

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025011904-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111705-4.3&flavor=update

system_tests_gui_tools
- desktop_linux_manager_policy_edit: unnamed test (unknown)
- desktop_linux_manager_policy_edit: Failed (test died)
  # Test died: no candidate needle with tag(s) 'qubes-policy-editor-g...
system_tests_guivm_gui_interactive
- gui_filecopy: unnamed test (unknown)
- gui_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'file-copy-prompt' mat...
system_tests_usbproxy
- TC_00_USBProxy_debian-12-xfce: test_000_attach_detach (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_debian-12-xfce: test_010_attach_detach_vid_pid (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_debian-12-xfce: test_020_detach_on_remove (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_fedora-41-xfce: test_000_attach_detach (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_fedora-41-xfce: test_010_attach_detach_vid_pid (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_fedora-41-xfce: test_020_detach_on_remove (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_whonix-gateway-17: test_000_attach_detach (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_whonix-gateway-17: test_010_attach_detach_vid_pid (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_whonix-gateway-17: test_020_detach_on_remove (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_whonix-workstation-17: test_000_attach_detach (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_whonix-workstation-17: test_010_attach_detach_vid_pid (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_whonix-workstation-17: test_020_detach_on_remove (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_20_USBProxy_core3_debian-12-xfce: test_010_assign (failure)
  AssertionError: 1 != 0 : Device connection failed
- TC_20_USBProxy_core3_debian-12-xfce: test_011_assign_ask (failure)
  AssertionError: 1 != 0 : Device connection failed
- TC_20_USBProxy_core3_debian-12-xfce: test_020_attach (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_debian-12-xfce: test_030_detach (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_debian-12-xfce: test_050_list_attached (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_debian-12-xfce: test_060_auto_detach_on_remove (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_debian-12-xfce: test_061_auto_attach_on_reconnect (failure)
  AssertionError: 1 != 0 : Device reconnection failed
- TC_20_USBProxy_core3_debian-12-xfce: test_062_ask_to_attach_on_start (failure)
  AssertionError: 1 != 0 : Device reconnection failed
- TC_20_USBProxy_core3_debian-12-xfce: test_080_attach_existing_policy (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_fedora-41-xfce: test_010_assign (failure)
  AssertionError: 1 != 0 : Device connection failed
- TC_20_USBProxy_core3_fedora-41-xfce: test_011_assign_ask (failure)
  AssertionError: 1 != 0 : Device connection failed
- TC_20_USBProxy_core3_fedora-41-xfce: test_020_attach (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_fedora-41-xfce: test_030_detach (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_fedora-41-xfce: test_050_list_attached (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_fedora-41-xfce: test_060_auto_detach_on_remove (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_fedora-41-xfce: test_061_auto_attach_on_reconnect (failure)
  AssertionError: 1 != 0 : Device reconnection failed
- TC_20_USBProxy_core3_fedora-41-xfce: test_062_ask_to_attach_on_start (failure)
  AssertionError: 1 != 0 : Device reconnection failed
- TC_20_USBProxy_core3_fedora-41-xfce: test_080_attach_existing_policy (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_whonix-gateway-17: test_010_assign (failure)
  AssertionError: 1 != 0 : Device connection failed
- TC_20_USBProxy_core3_whonix-gateway-17: test_011_assign_ask (failure)
  AssertionError: 1 != 0 : Device connection failed
- TC_20_USBProxy_core3_whonix-gateway-17: test_020_attach (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_whonix-gateway-17: test_030_detach (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_whonix-gateway-17: test_050_list_attached (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_whonix-gateway-17: test_060_auto_detach_on_remove (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_whonix-gateway-17: test_061_auto_attach_on_reconnect (failure)
  AssertionError: 1 != 0 : Device reconnection failed
- TC_20_USBProxy_core3_whonix-gateway-17: test_062_ask_to_attach_on_start (failure)
  AssertionError: 1 != 0 : Device reconnection failed
- TC_20_USBProxy_core3_whonix-gateway-17: test_080_attach_existing_policy (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_whonix-workstation-17: test_010_assign (failure)
  AssertionError: 1 != 0 : Device connection failed
- TC_20_USBProxy_core3_whonix-workstation-17: test_011_assign_ask (failure)
  AssertionError: 1 != 0 : Device connection failed
- TC_20_USBProxy_core3_whonix-workstation-17: test_020_attach (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_whonix-workstation-17: test_030_detach (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_whonix-workstation-17: test_050_list_attached (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_whonix-workstation-17: test_060_auto_detach_on_remove (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_whonix-workstation-17: test_061_auto_attach_on_reconnect (failure)
  AssertionError: 1 != 0 : Device reconnection failed
- TC_20_USBProxy_core3_whonix-workstation-17: test_062_ask_to_attach_on_start (failure)
  AssertionError: 1 != 0 : Device reconnection failed
- TC_20_USBProxy_core3_whonix-workstation-17: test_080_attach_existing_policy (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
system_tests_dispvm
- TC_20_DispVM_fedora-41-xfce: test_100_open_in_dispvm (failure)
  AssertionError: './open-file test.txt' failed with ./open-file test...
system_tests_devices
- TC_00_List_whonix-gateway-17: test_001_list_loop_mounted (failure)
  AssertionError: Device test-inst-vm:loop0::0 (/tmp/test.img) should...
system_tests_kde_gui_interactive
- gui_keyboard_layout: wait_serial (wait serial expected)
  # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...
system_tests_guivm_vnc_gui_interactive
- gui_filecopy: unnamed test (unknown)
- gui_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'file-copy-prompt' mat...
system_tests_basic_vm_qrexec_gui_xfs
- TC_30_Gui_daemon: test_002_clipboard_200k (failure)
  AssertionError: '' != 'test123ab\ntest123ab\ntest123ab\ntest123a[21...
- TC_30_Gui_daemon: test_002_clipboard_300k (failure)
  : Clipboard copy operation failed - content...
system_tests_gui_tools@hw7
- desktop_linux_manager_policy_edit: unnamed test (unknown)
- desktop_linux_manager_policy_edit: Failed (test died)
  # Test died: no candidate needle with tag(s) 'qubes-policy-editor-g...

Failed tests

63 failures

system_tests_gui_tools
- desktop_linux_manager_policy_edit: unnamed test (unknown)
- desktop_linux_manager_policy_edit: Failed (test died)
  # Test died: no candidate needle with tag(s) 'qubes-policy-editor-g...
system_tests_guivm_gui_interactive
- gui_filecopy: unnamed test (unknown)
- gui_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'file-copy-prompt' mat...
system_tests_usbproxy
- TC_00_USBProxy_debian-12-xfce: test_000_attach_detach (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_debian-12-xfce: test_010_attach_detach_vid_pid (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_debian-12-xfce: test_020_detach_on_remove (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_fedora-41-xfce: test_000_attach_detach (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_fedora-41-xfce: test_010_attach_detach_vid_pid (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_fedora-41-xfce: test_020_detach_on_remove (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_whonix-gateway-17: test_000_attach_detach (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_whonix-gateway-17: test_010_attach_detach_vid_pid (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_whonix-gateway-17: test_020_detach_on_remove (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_whonix-workstation-17: test_000_attach_detach (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_whonix-workstation-17: test_010_attach_detach_vid_pid (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_00_USBProxy_whonix-workstation-17: test_020_detach_on_remove (failure)
  AssertionError: 1 != 0 : qubes.USBAttach call failed
- TC_20_USBProxy_core3_debian-12-xfce: test_010_assign (failure)
  AssertionError: 1 != 0 : Device connection failed
- TC_20_USBProxy_core3_debian-12-xfce: test_011_assign_ask (failure)
  AssertionError: 1 != 0 : Device connection failed
- TC_20_USBProxy_core3_debian-12-xfce: test_020_attach (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_debian-12-xfce: test_030_detach (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_debian-12-xfce: test_050_list_attached (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_debian-12-xfce: test_060_auto_detach_on_remove (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_debian-12-xfce: test_061_auto_attach_on_reconnect (failure)
  AssertionError: 1 != 0 : Device reconnection failed
- TC_20_USBProxy_core3_debian-12-xfce: test_062_ask_to_attach_on_start (failure)
  AssertionError: 1 != 0 : Device reconnection failed
- TC_20_USBProxy_core3_debian-12-xfce: test_080_attach_existing_policy (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_fedora-41-xfce: test_010_assign (failure)
  AssertionError: 1 != 0 : Device connection failed
- TC_20_USBProxy_core3_fedora-41-xfce: test_011_assign_ask (failure)
  AssertionError: 1 != 0 : Device connection failed
- TC_20_USBProxy_core3_fedora-41-xfce: test_020_attach (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_fedora-41-xfce: test_030_detach (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_fedora-41-xfce: test_050_list_attached (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_fedora-41-xfce: test_060_auto_detach_on_remove (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_fedora-41-xfce: test_061_auto_attach_on_reconnect (failure)
  AssertionError: 1 != 0 : Device reconnection failed
- TC_20_USBProxy_core3_fedora-41-xfce: test_062_ask_to_attach_on_start (failure)
  AssertionError: 1 != 0 : Device reconnection failed
- TC_20_USBProxy_core3_fedora-41-xfce: test_080_attach_existing_policy (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_whonix-gateway-17: test_010_assign (failure)
  AssertionError: 1 != 0 : Device connection failed
- TC_20_USBProxy_core3_whonix-gateway-17: test_011_assign_ask (failure)
  AssertionError: 1 != 0 : Device connection failed
- TC_20_USBProxy_core3_whonix-gateway-17: test_020_attach (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_whonix-gateway-17: test_030_detach (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_whonix-gateway-17: test_050_list_attached (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_whonix-gateway-17: test_060_auto_detach_on_remove (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_whonix-gateway-17: test_061_auto_attach_on_reconnect (failure)
  AssertionError: 1 != 0 : Device reconnection failed
- TC_20_USBProxy_core3_whonix-gateway-17: test_062_ask_to_attach_on_start (failure)
  AssertionError: 1 != 0 : Device reconnection failed
- TC_20_USBProxy_core3_whonix-gateway-17: test_080_attach_existing_policy (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_whonix-workstation-17: test_010_assign (failure)
  AssertionError: 1 != 0 : Device connection failed
- TC_20_USBProxy_core3_whonix-workstation-17: test_011_assign_ask (failure)
  AssertionError: 1 != 0 : Device connection failed
- TC_20_USBProxy_core3_whonix-workstation-17: test_020_attach (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_whonix-workstation-17: test_030_detach (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_whonix-workstation-17: test_050_list_attached (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_whonix-workstation-17: test_060_auto_detach_on_remove (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
- TC_20_USBProxy_core3_whonix-workstation-17: test_061_auto_attach_on_reconnect (failure)
  AssertionError: 1 != 0 : Device reconnection failed
- TC_20_USBProxy_core3_whonix-workstation-17: test_062_ask_to_attach_on_start (failure)
  AssertionError: 1 != 0 : Device reconnection failed
- TC_20_USBProxy_core3_whonix-workstation-17: test_080_attach_existing_policy (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed:
system_tests_dispvm
- TC_20_DispVM_fedora-41-xfce: test_100_open_in_dispvm (failure)
  AssertionError: './open-file test.txt' failed with ./open-file test...
system_tests_devices
- TC_00_List_whonix-gateway-17: test_001_list_loop_mounted (failure)
  AssertionError: Device test-inst-vm:loop0::0 (/tmp/test.img) should...
system_tests_kde_gui_interactive
- gui_keyboard_layout: wait_serial (wait serial expected)
  # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...
- gui_keyboard_layout: Failed (test died)
  # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...
system_tests_guivm_vnc_gui_interactive
- gui_filecopy: unnamed test (unknown)
- gui_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'file-copy-prompt' mat...
system_tests_basic_vm_qrexec_gui_xfs
- TC_30_Gui_daemon: test_002_clipboard_200k (failure)
  AssertionError: '' != 'test123ab\ntest123ab\ntest123ab\ntest123a[21...
- TC_30_Gui_daemon: test_002_clipboard_300k (failure)
  : Clipboard copy operation failed - content...
system_tests_gui_tools@hw7
- desktop_linux_manager_policy_edit: unnamed test (unknown)
- desktop_linux_manager_policy_edit: Failed (test died)
  # Test died: no candidate needle with tag(s) 'qubes-policy-editor-g...
system_tests_basic_vm_qrexec_gui_zfs
- switch_pool: Failed (test died)
  # Test died: command 'qubes-dom0-update -y zfs' failed at /usr/lib/...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/119126#dependencies

2 fixed

system_tests_extra
- TC_00_QVCTest_whonix-gateway-17: test_010_screenshare (failure)
  ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0
system_tests_audio@hw1
- TC_20_AudioVM_PipeWire_whonix-workstation-17: test_260_audio_mic_enabled_switch_audiovm (failure)
  AssertionError: too short audio, expected 10s, got 0.00013605442176...

Unstable tests

Support ptyxis in qubes-run-terminal

9c4d5ce

Fedora 41 defaults to using ptyxis as its terminal instead of gnome-terminal. It also works correctly in dispVMs without needing any special --wait handling.

marmarek added the openqa-pending label Jan 17, 2025

qubesos-bot mentioned this pull request Jan 17, 2025

Do not close FDs 0, 1, or 2 QubesOS/qubes-core-qrexec#186

Open

marmarek approved these changes Jan 19, 2025

View reviewed changes

marmarek merged commit 9c4d5ce into QubesOS:main Jan 19, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support ptyxis in qubes-run-terminal #546

Support ptyxis in qubes-run-terminal #546

legoktm commented Jan 14, 2025

codecov bot commented Jan 14, 2025 •

edited

Loading

qubesos-bot commented Jan 17, 2025 •

edited

Loading

Support ptyxis in qubes-run-terminal #546

Support ptyxis in qubes-run-terminal #546

Conversation

legoktm commented Jan 14, 2025

codecov bot commented Jan 14, 2025 • edited Loading

Codecov Report

qubesos-bot commented Jan 17, 2025 • edited Loading

OpenQA test summary

New failures, excluding unstable

Failed tests

Fixed failures

Unstable tests

codecov bot commented Jan 14, 2025 •

edited

Loading

qubesos-bot commented Jan 17, 2025 •

edited

Loading