Fix ambiguous call to min function #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CsrMV function currently makes a call to min(int, uint32_t). Previously, clang headers only defined min(int, int), so this would cause the second argument to be implicitly cast to int. However, in the future Clang will add overloaded versions of min like min(uint32_t, uint32_t). This will make the call ambiguous, since the compiler does not know whether to cast the first argument to uint32_t, or to cast the second argument to int. This change adds an explicit cast here to prevent future problems.
umfranzw
requested review from
stanleytsang-amd,
RobsonRLemos and
lawruble13
as code owners
|
do we have an estimation when this can get to master branch? thanks. |
stanleytsang-amd
approved these changes
Mar 11, 2024
|
CI build errors look due to jenkins being unable to pull the last successful artifact from rocPRIM; i dont see how this PR could break anything, so i'll approve it. @umfranzw is this ready to be a non-draft PR? |
|
Thanks @stanleytsang-amd, yes, I believe this is ready to go now. |
yxsamliu
reviewed
May 30, 2024
| @@ -139,7 +139,7 @@ template <typename ValueT> | |||
| } | |||
| else | |||
| { | |||
| size_t block_size = min(num_cols, DeviceSpmv::CsrMVKernel_MaxThreads); | |||
| size_t block_size = min(static_cast<int>(num_cols), DeviceSpmv::CsrMVKernel_MaxThreads); | |||
There was a problem hiding this comment.
the fix does not work.
should be
size_t block_size = min(num_cols, static_cast<int>(DeviceSpmv::CsrMVKernel_MaxThreads));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CsrMV function currently makes a call to min(int, uint32_t). Previously, clang headers only defined min(int, int), so this would cause the second argument to be implicitly cast to int.
However, in the future Clang will add overloaded versions of min like min(uint32_t, uint32_t) - see this issue. This will make the call ambiguous, since the compiler does not know whether to cast the first argument to uint32_t, or to cast the second argument to int.
This change adds an explicit cast here to prevent future problems.